[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

arlosi abandoned this revision. arlosi added a comment. Closing in favor of D134544 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/ https://reviews.llvm.org/D98438

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

probinson added a comment. So this one can be marked abandoned? You might need to commandeer it first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/ https://reviews.llvm.org/D98438 ___

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

thakis added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. I addressed pending comments, did some other minor tweaks, and uploaded the modified diff to D134544 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

I wouldn't be able to look at this for a few weeks. If you have the time to take it over, that works for me. Thanks! On Fri, Jan 21, 2022, 07:24 Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added a comment. > > Do you think you'll have time to work on this? Otherwise

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

hans added a comment. Do you think you'll have time to work on this? Otherwise I'd be happy to take it over. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/ https://reviews.llvm.org/D98438 ___

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

hans added a comment. Sorry for not seeing this sooner. I think this looks great, just a few comments, and it also needs tests. Comment at: clang/include/clang/Basic/CodeGenOptions.def:303 +/// Set debug info source file hashing algorithm

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

arlosi added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/ https://reviews.llvm.org/D98438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

arlosi updated this revision to Diff 330386. arlosi marked an inline comment as done. arlosi added a comment. Use automatic marshaling for command line arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2775 def gno_split_dwarf : Flag<["-"], "gno-split-dwarf">, Group; +def gsrc_hash_algorithm_EQ : Joined<["-"], "gsrc-hash-algorithm=">, Group, Flags<[CC1Option]>, + HelpText<"Hashing

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

arlosi created this revision. Herald added subscribers: jansvoboda11, dexonsmith, dang. arlosi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds clang-cl support for the /ZH: option used to select MD5, SHA1, or SHA_256 hashing