[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-22 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 402234. Ericson2314 added a comment. Trim down, now that many parts have been landed already Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-15 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added a comment. OK I split out D117417 , D117418 , D117419 , and D117420 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-15 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Will try to break up the pathc further for better troubleshooting, but keeping this open to track progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-15 Thread John Ericson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a678f807200: [cmake] Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson2314). Repository: rG LLVM Github Monorepo

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-14 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 400253. Ericson2314 added a comment. Try again, with more `include(GNUInstallDirs)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-14 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Found two more `include(GNUInstallDirs)` I should include which will hopefully fix the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-14 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added a comment. Sorry about that. I think the issue was just one more `include(GNUInstallDirs)` for compiler-rt for the standalone build, but I am going to bed so just reverted for now to try again later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-14 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. It breaks multiple bots. https://lab.llvm.org/buildbot/#/builders/37/builds/9960 https://lab.llvm.org/buildbot/#/builders/77/builds/13245 https://lab.llvm.org/buildbot/#/builders/169/builds/5409 https://lab.llvm.org/buildbot/#/builders/105/builds/19941 Can you please

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-14 Thread John Ericson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rGefeb50197091: [cmake] Use `GNUInstallDirs` to support custom installation dirs. (authored by

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-14 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 marked 3 inline comments as done. Ericson2314 added inline comments. Comment at: polly/cmake/CMakeLists.txt:85 +set(POLLY_CONFIG_CMAKE_DIR "${POLLY_INSTALL_PREFIX}${CMAKE_INSTALL_PREFIX}/${POLLY_INSTALL_PACKAGE_DIR}") +set(POLLY_CONFIG_LIBRARY_DIRS

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-14 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 marked 10 inline comments as done. Ericson2314 added a comment. The approval on this patch is quite old, but nothing much interesting has happened in it since then --- if anything, it has gotten more trivial as I created patches "under" it and landed them which cleared the way for

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-13 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 399883. Ericson2314 added a comment. Rebase after landing the polly change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-11 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 399096. Ericson2314 added a comment. Retrigger CI now that deps are fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-11 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 399020. Ericson2314 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

2022-01-10 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 398857. Ericson2314 added a comment. Fix conflicts, one more thing for openmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: