[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/16663/step_7.txt Please to a look. Just adding a -triple flag is probably sufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a5f38885056: [AST] Pick last tentative definition as the acting definition (authored by pestctrl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl added a comment. @mizvekov Thanks for the help! I recently got commit access, so I think I can commit this myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl updated this revision to Diff 366522. pestctrl added a comment. Only look for attributes in check string for unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 Files:

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl updated this revision to Diff 366513. pestctrl added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 Files: clang/lib/AST/Decl.cpp

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

mizvekov added a comment. Do you need help merging this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/AST/Decl.cpp:2203 return nullptr; -if (Kind == TentativeDefinition) - LastTentative = I; +// Record the first

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl marked an inline comment as done. pestctrl added a comment. @rsmith Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 ___ cfe-commits mailing list

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl added inline comments. Comment at: clang/lib/AST/Decl.cpp:2192 DefinitionKind Kind = isThisDeclarationADefinition(); - if (Kind != TentativeDefinition) + if (Kind != TentativeDefinition || hasDefinition()) return nullptr; rsmith wrote: > Is

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl updated this revision to Diff 335113. pestctrl edited the summary of this revision. pestctrl added a comment. Removed extra pass over decl chain for acting definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

rsmith added a comment. Thanks, this makes sense. Comment at: clang/lib/AST/Decl.cpp:2192 DefinitionKind Kind = isThisDeclarationADefinition(); - if (Kind != TentativeDefinition) + if (Kind != TentativeDefinition || hasDefinition()) return nullptr;

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl created this revision. pestctrl added reviewers: akyrtzi, rsmith. pestctrl added a project: clang. pestctrl requested review of this revision. Herald added a subscriber: cfe-commits. I noticed this bug because attributes were being dropped from tentative definitions after the second