[PATCH] D99830: [DebugInfo, CallSites, test] Fix use of undef FileCheck var
This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd3e0feca92: [DebugInfo, CallSites, test] Fix use of undef FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99830/new/ https://reviews.llvm.org/D99830 Files: clang/test/CodeGen/debug-info-extern-call.c Index: clang/test/CodeGen/debug-info-extern-call.c === --- clang/test/CodeGen/debug-info-extern-call.c +++ clang/test/CodeGen/debug-info-extern-call.c @@ -21,8 +21,7 @@ // RUN: %clang -g -O2 -target x86_64-none-linux-gnu -gsce -S -emit-llvm %s -o - \ // RUN: | FileCheck %s -check-prefix=NO-DECLS-FOR-EXTERN -// DECLS-FOR-EXTERN-NOT: !DICompileUnit({{.*}}retainedTypes: ![[RETTYPES:[0-9]+]] -// DECLS-FOR-EXTERN-NOT: ![[RETTYPES]] = !{ +// DECLS-FOR-EXTERN-NOT: !DICompileUnit({{.*}}retainedTypes: !{{[0-9]+}} // DECLS-FOR-EXTERN: !DISubprogram(name: "fn1" // DECLS-FOR-EXTERN-NOT: !DISubprogram(name: "memcmp" // DECLS-FOR-EXTERN-NOT: !DISubprogram(name: "__some_reserved_name" Index: clang/test/CodeGen/debug-info-extern-call.c === --- clang/test/CodeGen/debug-info-extern-call.c +++ clang/test/CodeGen/debug-info-extern-call.c @@ -21,8 +21,7 @@ // RUN: %clang -g -O2 -target x86_64-none-linux-gnu -gsce -S -emit-llvm %s -o - \ // RUN: | FileCheck %s -check-prefix=NO-DECLS-FOR-EXTERN -// DECLS-FOR-EXTERN-NOT: !DICompileUnit({{.*}}retainedTypes: ![[RETTYPES:[0-9]+]] -// DECLS-FOR-EXTERN-NOT: ![[RETTYPES]] = !{ +// DECLS-FOR-EXTERN-NOT: !DICompileUnit({{.*}}retainedTypes: !{{[0-9]+}} // DECLS-FOR-EXTERN: !DISubprogram(name: "fn1" // DECLS-FOR-EXTERN-NOT: !DISubprogram(name: "memcmp" // DECLS-FOR-EXTERN-NOT: !DISubprogram(name: "__some_reserved_name" ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D99830: [DebugInfo, CallSites, test] Fix use of undef FileCheck var
thopre created this revision. thopre added reviewers: djtodoro, vsk. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGen/debug-info-extern-call.c tries to check for the absence of a sequence of instructions with several CHECK-NOT with one of those directives using a variable defined in another. However CHECK-NOT are checked independently so that is using a variable defined in a pattern that should not occur in the input. This commit removes the CHECK-NOT for the retained line attribute definition since the CHECK-NOT on the compile unit will already check that there is no retained lines. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99830 Files: clang/test/CodeGen/debug-info-extern-call.c Index: clang/test/CodeGen/debug-info-extern-call.c === --- clang/test/CodeGen/debug-info-extern-call.c +++ clang/test/CodeGen/debug-info-extern-call.c @@ -21,8 +21,7 @@ // RUN: %clang -g -O2 -target x86_64-none-linux-gnu -gsce -S -emit-llvm %s -o - \ // RUN: | FileCheck %s -check-prefix=NO-DECLS-FOR-EXTERN -// DECLS-FOR-EXTERN-NOT: !DICompileUnit({{.*}}retainedTypes: ![[RETTYPES:[0-9]+]] -// DECLS-FOR-EXTERN-NOT: ![[RETTYPES]] = !{ +// DECLS-FOR-EXTERN-NOT: !DICompileUnit({{.*}}retainedTypes: !{{[0-9]+}} // DECLS-FOR-EXTERN: !DISubprogram(name: "fn1" // DECLS-FOR-EXTERN-NOT: !DISubprogram(name: "memcmp" // DECLS-FOR-EXTERN-NOT: !DISubprogram(name: "__some_reserved_name" Index: clang/test/CodeGen/debug-info-extern-call.c === --- clang/test/CodeGen/debug-info-extern-call.c +++ clang/test/CodeGen/debug-info-extern-call.c @@ -21,8 +21,7 @@ // RUN: %clang -g -O2 -target x86_64-none-linux-gnu -gsce -S -emit-llvm %s -o - \ // RUN: | FileCheck %s -check-prefix=NO-DECLS-FOR-EXTERN -// DECLS-FOR-EXTERN-NOT: !DICompileUnit({{.*}}retainedTypes: ![[RETTYPES:[0-9]+]] -// DECLS-FOR-EXTERN-NOT: ![[RETTYPES]] = !{ +// DECLS-FOR-EXTERN-NOT: !DICompileUnit({{.*}}retainedTypes: !{{[0-9]+}} // DECLS-FOR-EXTERN: !DISubprogram(name: "fn1" // DECLS-FOR-EXTERN-NOT: !DISubprogram(name: "memcmp" // DECLS-FOR-EXTERN-NOT: !DISubprogram(name: "__some_reserved_name" ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits