[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- abandoned this revision. Qix- added a comment. Closing in favor of more complete plugin attribute changes discussed in IRC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/ https://reviews.llvm.org/D99861

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

aaron.ballman added a comment. In D99861#2697449 , @Qix- wrote: > I'm not sure exactly how to continue after the last few comments - what > should the approach be for this patch? Or are these things we can shoot for > in later patches? I don't think

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- added a comment. I'm not sure exactly how to continue after the last few comments - what should the approach be for this patch? Or are these things we can shoot for in later patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

aaron.ballman added a comment. In D99861#2694605 , @urnathan wrote: > See also https://bugs.llvm.org/show_bug.cgi?id=46446. when I first fell into > this issue, I did think it was trying to save the token stream as this patch > is doing. Neat I

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

urnathan added a comment. See also https://bugs.llvm.org/show_bug.cgi?id=46446. when I first fell into this issue, I did think it was trying to save the token stream as this patch is doing. Neat I thought :) although I'm a clang weenie, saving the tokens is putting this into deferred-parse

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- added a comment. @aaron.ballman updated with comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/ https://reviews.llvm.org/D99861 ___ cfe-commits mailing list

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- updated this revision to Diff 336614. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/ https://reviews.llvm.org/D99861 Files: clang/examples/CMakeLists.txt clang/examples/PrintAttributeTokens/CMakeLists.txt

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- marked an inline comment as not done. Qix- added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4100-4102 + // directly. The recording happens here because this is the only place + // where user-defined (via plugins) attributes are parsed, and thus + //

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- marked 3 inline comments as done. Qix- added a comment. So I went back and checked and I remember why I didn't add explicit support for GNU/declspec attributes - they actually perform symbol lookups in the surrounding scope. I believe there's an issue right now with plugins that GNU-style

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- planned changes to this revision. Qix- marked 5 inline comments as done. Qix- added inline comments. Comment at: clang/examples/PrintAttributeTokens/CMakeLists.txt:3-10 +if( NOT MSVC ) # MSVC mangles symbols differently, and + # PrintAttributeTokens.export

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

aaron.ballman added reviewers: rsmith, erichkeane. aaron.ballman added a comment. Thank you for this patch, I think it's really useful functionality for plugin authors! Adding some additional reviewers for more opinions on the changes in the preprocessor. Comment at:

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- updated this revision to Diff 336173. Qix- added a comment. Updated the diff to include a lot more context (-U). Thanks again for the tip :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/ https://reviews.llvm.org/D99861 Files:

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- created this revision. Qix- added a reviewer: aaron.ballman. Qix- added a project: clang. Herald added a subscriber: mgorny. Qix- requested review of this revision. Herald added a subscriber: cfe-commits. Currently, user-defined attributes (e.g. those registered via Clang plugins) don't