https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/69244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
My main two reviewers are away this week, and the review I got caught the
'dumb' stuff I'm likely to miss anyway. So I'm going to merge this to give it
more time to bake, and count on RAC.
https://github.com/llvm/llvm-project/pull/69244
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/69244
>From 810d49553eac0e42697283b008810cdc37971dd0 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 16 Oct 2023 13:02:14 -0700
Subject: [PATCH 1/3] [CONCEPTS]Corrected comparison of constraints with out of
@@ -346,6 +351,11 @@ MultiLevelTemplateArgumentList
Sema::getTemplateInstantiationArgs(
CurDecl = Response::UseNextDecl(ND).NextDecl;
}
+ if (!ND) {
+assert(DC);
erichkeane wrote:
Probably not necessary, I'll remove it. I think I added that top
@@ -8615,8 +8604,48 @@ class Sema final {
TPL_TemplateParamsEquivalent,
};
+ // A struct to represent the 'new' declaration, which is either itself just
+ // the named decl, or the important information we need about it in order to
+ // do constraint comparisions.
@@ -346,6 +351,11 @@ MultiLevelTemplateArgumentList
Sema::getTemplateInstantiationArgs(
CurDecl = Response::UseNextDecl(ND).NextDecl;
}
+ if (!ND) {
+assert(DC);
Fznamznon wrote:
Does this assertion makes sense? If `ND` and `DC` both were null,
erichkeane wrote:
I did a force-push with the hope that it'll get the code-formatter to start
recognizing what is going on, it seems to be doing some wacky things?
https://github.com/llvm/llvm-project/pull/69244
___
cfe-commits mailing list
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/69244
>From 810d49553eac0e42697283b008810cdc37971dd0 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 16 Oct 2023 13:02:14 -0700
Subject: [PATCH 1/2] [CONCEPTS]Corrected comparison of constraints with out of
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/69244
>From 021ec9d584dffc6852a777effc50843bd0facaa1 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Mon, 16 Oct 2023 13:02:14 -0700
Subject: [PATCH 1/2] [CONCEPTS]Corrected comparison of constraints with out of
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erich Keane (erichkeane)
Changes
Out of line class template declaration specializations aren't created at the
time they have their template arguments checked, so we previously weren't doing
any amount of work to substitute the
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/69244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/69244
Out of line class template declaration specializations aren't created at the
time they have their template arguments checked, so we previously weren't doing
any amount of work to substitute the constraints
12 matches
Mail list logo
