https://github.com/lukel97 closed
https://github.com/llvm/llvm-project/pull/76962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/BeMg approved this pull request.
https://github.com/llvm/llvm-project/pull/76962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lukel97 updated
https://github.com/llvm/llvm-project/pull/76962
>From dfaf782113b977c9960358adab88767e23ddbc56 Mon Sep 17 00:00:00 2001
From: Luke Lau
Date: Thu, 4 Jan 2024 20:48:09 +0700
Subject: [PATCH 1/2] [RISCV] Fix collectNonISAExtFeature returning negative
extension
@@ -237,22 +237,15 @@ ArrayRef
RISCVTargetInfo::getTargetBuiltins() const {
static std::vector
collectNonISAExtFeature(ArrayRef FeaturesNeedOverride, int XLen) {
- auto ParseResult =
- llvm::RISCVISAInfo::parseFeatures(XLen, FeaturesNeedOverride);
-
- if
lukel97 wrote:
Note that this doesn't fix the issue described in
https://github.com/llvm/llvm-project/pull/74889#pullrequestreview-1773445559.
One approach that would build upon this would be to use the entire list of
target features including negative extensions when a full arch string is
https://github.com/lukel97 updated
https://github.com/llvm/llvm-project/pull/76962
>From dfaf782113b977c9960358adab88767e23ddbc56 Mon Sep 17 00:00:00 2001
From: Luke Lau
Date: Thu, 4 Jan 2024 20:48:09 +0700
Subject: [PATCH] [RISCV] Fix collectNonISAExtFeature returning negative
extension
https://github.com/lukel97 edited
https://github.com/llvm/llvm-project/pull/76962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Luke Lau (lukel97)
Changes
collectNonISAExtFeature was returning any negative extension features, e.g.
given an input of
+zifencei,+m,+a,+save-restore,-zbb,-relax,-zfa
It would return
+save-restore,-zbb,-relax,-zfa
Because
https://github.com/lukel97 created
https://github.com/llvm/llvm-project/pull/76962
collectNonISAExtFeature was returning any negative extension features, e.g.
given an input of
+zifencei,+m,+a,+save-restore,-zbb,-relax,-zfa
It would return
+save-restore,-zbb,-relax,-zfa
Because negative
