brad0 wrote:
Any chance of reviving this?
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brad0 wrote:
Ping.
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brad0 wrote:
Able to look at this further?
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alanzhao1 wrote:
If we pass `-v` to Clang, we get the following include directories:
without this patch:
```
clang -cc1 version 18.0.0git based upon LLVM 18.0.0git default target
arm64-apple-darwin23.3.0
ignoring nonexistent directory
alanzhao1 wrote:
Here's what I did to repro:
`include.cc`:
```cpp
#include
```
Build clang:
```
$ cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_LLD=False
-DLLVM_CCACHE_BUILD=True -DLLVM_ENABLE_PROJECTS="clang"
-DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64" ../llvm
$ ninja clang
```
I
aeubanks wrote:
sorry, I keep missing notifications, will find a repro
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Ping. I don't know how to fix the issue, I need some help.
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
No, I would like to reproduce locally.
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aeubanks wrote:
is the clang invocation in the logs I posted sufficient?
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@aeubanks @petrhosek Can you folks share what was the top level invocations you
did to get those errors? I am having trouble understanding the problem just
from the pasted errors.
https://github.com/llvm/llvm-project/pull/75841
___
fhahn wrote:
@aeubanks thanks for the revert!
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aeubanks wrote:
I've reverted this, hopefully the command line in the failing invocation I gave
is enough to repro the regression, otherwise lmk what else I can do to help
repro
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing
aeubanks wrote:
same in our stage 2 build
```
[4643/5157] Building CXX object
tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o
FAILED: tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o
/Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm-bootstrap-install/bin/clang++
petrhosek wrote:
This appears to have broken the LSan build which is now failing with the
following error:
```
FAILED:
compiler-rt/lib/lsan/CMakeFiles/clang_rt.lsan_osx_dynamic.dir/lsan_malloc_mac.cpp.o
/Volumes/Work/s/w/ir/x/w/llvm_build/./bin/clang++
--target=x86_64-apple-darwin22.6.0
brad0 wrote:
Thank you for the effort.
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
I think this can be merged. I would have liked to have @jlebar 's input on
interactions with Cuda, but I think this is probably good enough.
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
brad0 wrote:
Update?
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yln approved this pull request.
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -758,9 +758,14 @@ void darwin::Linker::ConstructJob(Compilation , const
JobAction ,
}
}
- // Add non-standard, platform-specific search paths, e.g., for DriverKit:
- // -L/System/DriverKit/usr/lib
- // -F/System/DriverKit/System/Library/Framework
+ // Add
https://github.com/yln edited https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/75841
>From ca2a85880cec704225c0b1d5241cf299d5dcad41 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 18 Dec 2023 12:53:23 -0500
Subject: [PATCH 1/2] [clang][Darwin] Remove legacy framework search path logic
in
ldionne wrote:
@jlebar The CI seems to be failing due to a test you were the last to touch:
```
TEST 'Clang :: Preprocessor/cuda-macos-includes.cu' FAILED
Exit Code: 1
Command Output (stderr):
--
[...]
error: CHECK-DAG: expected string not found in
@@ -758,9 +758,14 @@ void darwin::Linker::ConstructJob(Compilation , const
JobAction ,
}
}
- // Add non-standard, platform-specific search paths, e.g., for DriverKit:
- // -L/System/DriverKit/usr/lib
- // -F/System/DriverKit/System/Library/Framework
+ // Add
@@ -758,9 +758,14 @@ void darwin::Linker::ConstructJob(Compilation , const
JobAction ,
}
}
- // Add non-standard, platform-specific search paths, e.g., for DriverKit:
- // -L/System/DriverKit/usr/lib
- // -F/System/DriverKit/System/Library/Framework
+ // Add
@@ -758,9 +758,14 @@ void darwin::Linker::ConstructJob(Compilation , const
JobAction ,
}
}
- // Add non-standard, platform-specific search paths, e.g., for DriverKit:
- // -L/System/DriverKit/usr/lib
- // -F/System/DriverKit/System/Library/Framework
+ // Add
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Louis Dionne (ldionne)
Changes
This removes a long standing piece of technical debt. Most other platforms have
moved all their header search path logic to the driver, but Darwin still had
some logic for setting framework search paths
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/75841
This removes a long standing piece of technical debt. Most other platforms have
moved all their header search path logic to the driver, but Darwin still had
some logic for setting framework search paths present
28 matches
Mail list logo
