[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

tbaederr wrote: Yeah sorry for the unnecessary ping :) I'll push as soon as the CI is done. https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

cor3ntin wrote: @tbaederr Shafik already approved that - still looks good :) https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67229 >From 32d5ecddc5b6aff0924b48a0b35128be7b07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 23 Sep 2023 11:41:52 +0200 Subject: [PATCH] [clang][Interp] Fix returning nullptr from

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67229 >From c3fcded8f926789ee6b00dcb676231b3c8285ac6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 23 Sep 2023 11:41:52 +0200 Subject: [PATCH] [clang][Interp] Fix returning nullptr from

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

@@ -209,7 +209,7 @@ bool Ret(InterpState , CodePtr , APValue ) { // FIXME: We could be calling isLive() here, but the emitted diagnostics // seem a little weird, at least if the returned expression is of // pointer type. shafik wrote: Can we add

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

https://github.com/shafik approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

llvmbot wrote: @llvm/pr-subscribers-clang Changes isLive() is false for null pointers, so we need to special-case this here. --- Full diff: https://github.com/llvm/llvm-project/pull/67229.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/Interp.h (+1-1) - (modified)

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/67229 isLive() is false for null pointers, so we need to special-case this here. >From 60a6eade88991e9f80627cb52eb55c1aecbbc1cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 23 Sep 2023