https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/68540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/68540
>From 613ea6809b478ff7391614b24ec177fc19339cdd Mon Sep 17 00:00:00 2001
From: Leonardo Duarte
Date: Sun, 8 Oct 2023 12:59:15 +0200
Subject: [PATCH 1/7] [clang][Sema] Emit more specific diagnostic for auto in
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/68540
>From 613ea6809b478ff7391614b24ec177fc19339cdd Mon Sep 17 00:00:00 2001
From: Leonardo Duarte
Date: Sun, 8 Oct 2023 12:59:15 +0200
Subject: [PATCH 1/6] [clang][Sema] Emit more specific diagnostic for auto in
cor3ntin wrote:
@shafik ping
https://github.com/llvm/llvm-project/pull/68540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@shafik I'll let you have the final say :)
https://github.com/llvm/llvm-project/pull/68540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weltschildkroete edited
https://github.com/llvm/llvm-project/pull/68540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weltschildkroete updated
https://github.com/llvm/llvm-project/pull/68540
>From 613ea6809b478ff7391614b24ec177fc19339cdd Mon Sep 17 00:00:00 2001
From: Leonardo Duarte
Date: Sun, 8 Oct 2023 12:59:15 +0200
Subject: [PATCH 1/6] [clang][Sema] Emit more specific diagnostic for
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 606f89ab7d537ca068fb1be9fd89d96a30de38f8
031e76900f6e63c97ed8666066ff98d967305af4 --
@@ -3605,8 +3605,11 @@ static QualType
GetDeclSpecTypeForDeclarator(TypeProcessingState ,
Info = ();
} else {
// In C++14, generic lambdas allow 'auto' in their parameters.
-if (!SemaRef.getLangOpts().CPlusPlus14 || !Auto ||
-
https://github.com/weltschildkroete updated
https://github.com/llvm/llvm-project/pull/68540
>From 613ea6809b478ff7391614b24ec177fc19339cdd Mon Sep 17 00:00:00 2001
From: Leonardo Duarte
Date: Sun, 8 Oct 2023 12:59:15 +0200
Subject: [PATCH 1/5] [clang][Sema] Emit more specific diagnostic for
@@ -3605,8 +3605,11 @@ static QualType
GetDeclSpecTypeForDeclarator(TypeProcessingState ,
Info = ();
} else {
// In C++14, generic lambdas allow 'auto' in their parameters.
-if (!SemaRef.getLangOpts().CPlusPlus14 || !Auto ||
-
weltschildkroete wrote:
LMK if the release note sounds good. If so, could you land this patch for me?
Please use "Leonardo Duarte weltschildkro...@gmail.com" to commit the change.
Thanks!
https://github.com/llvm/llvm-project/pull/68540
___
@@ -2393,7 +2393,7 @@ def err_auto_not_allowed : Error<
"|in type allocated by 'new'|in K function parameter"
"|in template parameter|in friend declaration|in function prototype that is "
"not a function declaration|in requires expression parameter"
- "|in array
https://github.com/weltschildkroete updated
https://github.com/llvm/llvm-project/pull/68540
>From 613ea6809b478ff7391614b24ec177fc19339cdd Mon Sep 17 00:00:00 2001
From: Leonardo Duarte
Date: Sun, 8 Oct 2023 12:59:15 +0200
Subject: [PATCH 1/4] [clang][Sema] Emit more specific diagnostic for
https://github.com/weltschildkroete updated
https://github.com/llvm/llvm-project/pull/68540
>From 613ea6809b478ff7391614b24ec177fc19339cdd Mon Sep 17 00:00:00 2001
From: Leonardo Duarte
Date: Sun, 8 Oct 2023 12:59:15 +0200
Subject: [PATCH 1/3] [clang][Sema] Emit more specific diagnostic for
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/68540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
A small nit, otherwise LGTM
I'm not sure it's strictly necessary here, but you could add a release note in
clang/docs/ReleaseNotes.rst - under the diagnostics improvement section
https://github.com/llvm/llvm-project/pull/68540
@@ -2393,7 +2393,7 @@ def err_auto_not_allowed : Error<
"|in type allocated by 'new'|in K function parameter"
"|in template parameter|in friend declaration|in function prototype that is "
"not a function declaration|in requires expression parameter"
- "|in array
weltschildkroete wrote:
> Thanks for this patch!
Thank you for the feedback and for your patience. :-)
It should be fixed now (hopefully!)
https://github.com/llvm/llvm-project/pull/68540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/weltschildkroete updated
https://github.com/llvm/llvm-project/pull/68540
>From 7e62fe6179dc63e9930a77c6996ae651d4489aa2 Mon Sep 17 00:00:00 2001
From: Leonardo Duarte
Date: Sun, 8 Oct 2023 12:59:15 +0200
Subject: [PATCH] [clang][Sema] Emit more specific diagnostic for auto
cor3ntin wrote:
Thanks for this patch!
Our policy is to not mix functional changes and formatting changes.
Could you change the PR to have only the changes you made, wit no formatting
change?
You can format your patch with `git clang-format` which only formats the lines
that you changed.
21 matches
Mail list logo
