AaronBallman wrote:
> @AaronBallman Can you merge this please? We are eagerly waiting for this to
> end up in a release! ;-)
Thank you for the ping, this fell off my radar!
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bebuch wrote:
@AaronBallman Can you merge this please? We are eagerly waiting for this to end
up in a release! ;-)
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaxEW707 wrote:
Friendly reminder that I require someone to commit on my behalf since I do not
have write access :).
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/CaseyCarter approved this pull request.
Thanks for devising this clever way to improve MSVCSTL throughput!
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/AaronBallman approved this pull request.
LGTM, thank you!
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
Just want to say thanks for everyone taking the time to review the PR and
providing feedback :).
Looking forward to using this in the next release of clang-cl.
> I'm a bit worried that we don't have any test coverage for this file to begin
> with, so it's a bit hard to
https://github.com/AaronBallman approved this pull request.
Thank you for the timing information! The yvals_core.h hack is actually a
really clever way to handle this. I'm a bit worried that we don't have any test
coverage for this file to begin with, so it's a bit hard to validate that the
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,26 @@
+/* === vadefs.h ---===
+ *
+ * Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+ * See https://llvm.org/LICENSE.txt for license information.
+ * SPDX-License-Identifier:
MaxEW707 wrote:
I will need someone to commit on my behalf since I do not have write access.
> lgtm, and good to land provided you do a quick re-check to confirm that this
> doesn't tank compile times now with that part included. Thanks!
The include times below are done with the following
MaskRay wrote:
I am not familiar with the MSVC ecosystem, but the change looks reasonable.
Thanks!
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,26 @@
+/* === vadefs.h ---===
+ *
+ * Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+ * See https://llvm.org/LICENSE.txt for license information.
+ * SPDX-License-Identifier:
https://github.com/rnk approved this pull request.
I think there are risks to shadowing `yvals_core.h`, but @CaseyCarter is at
least aware of it
[here](https://github.com/microsoft/STL/issues/3634#issuecomment-1904956652).
Once Clang ships its own intrin0.h header, the MSVC STL can adjust
nico wrote:
Wow, that clang/lib/Headers/yvals_core.h hacks is gross, I love it :D
lgtm, and good to land provided you do a quick re-check to confirm that this
doesn't tank compile times now with that part included. Thanks!
https://github.com/llvm/llvm-project/pull/75711
MaxEW707 wrote:
Ping
Wondering if there is anything else required of me to progress this PR forward.
Let me know :).
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaxEW707 wrote:
> Users (Chromium included) use recent versions of Clang that are not vendored
> by Microsoft. Users can also use the LLVM OSS releases. I think most users
> probably won't notice the compile time regression, and it will silently go
> away the next time the update MSVC, but if
@@ -0,0 +1,160 @@
+/*=== adxintrin.h - ADX intrinsics -===
phoebewang wrote:
adx -> adc
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
MaxEW707 wrote:
> @MaxEW707 If you pull out the adcintrin.h change into a separate PR we can
> fast track it as it should be done anyhow
Done :). Here is the link since I can't add reviewers
https://github.com/llvm/llvm-project/pull/75992.
https://github.com/llvm/llvm-project/pull/75711
RKSimon wrote:
@MaxEW707 If you pull out the adcintrin.h change into a separate PR we can fast
track it as it should be done anyhow
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaxEW707 wrote:
MSVC STL requires the x64 adc intel intrinsics. I moved those to a separate
file `adcintrin.h` that can be included from `immintrin.h` and `intrin0.h` for
x64.
I also made a table [here
](https://gist.github.com/MaxEW707/2f4bf26801bc1b6b088aa7a2fadba526) of all the
rnk wrote:
> > What I'd like to see is a pull request sent to
> > https://github.com/microsoft/stl with some agreement about how to structure
> > the ifdefs so we can use intrin0.h when it is available.
>
> Sounds good I'll do that.
Thanks!
> I was thinking I could use `__has_include_next`.
MaxEW707 wrote:
> Is intrin0.h a header that ships with MSVC's compiler, or with MS's STL? If
> the latter, shouldn't everything just work already?
It ships with MSVC.
`intrin0.h` from MSVC doesn't work currently due to some declarations not
matching declarations in clang's own `intrin.h`.
rnk wrote:
> If we land this as-is, it'll tank build time on Windows.
While this is true, I don't think it's the right tradeoff for us to leave Intel
intrinsics inaccessible for users who don't want to enable new
microarchitectural features globally with command line flags. You may recall
nico wrote:
In other words, please undo the changes to `clang/lib/Headers/immintrin.h` for
now.
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nico wrote:
Looks like it belongs to MSVC:
https://github.com/microsoft/STL/blob/a806c6960f1687590ffd4244794c753aa819/stl/inc/yvals_core.h#L2040
So I think the right order here is:
1. Add intrin0.h header
2. Wait for a release
3. Change MSSTL to include that in clang builds as well
4.
nico wrote:
Is `intrin0.h` a header that ships with MSVC's compiler, or with MS's STL? If
the latter, shouldn't everything just work already?
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/75711
>From 8cd6db09c511ad8fde0e54e96cf3019da5b40d6e Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Sat, 16 Dec 2023 13:54:16 -0500
Subject: [PATCH 1/3] Add `intrin0.h`
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b3e353d263f9d6ef061f4e6d89619c72a3553002
8cd6db09c511ad8fde0e54e96cf3019da5b40d6e --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (MaxEW707)
Changes
Fixes https://github.com/llvm/llvm-project/issues/53520.
Description
Provide `intrin0.h` to be the minimal set of intrinsics that the MSVC STL
requires.
The `intrin0.h` header matches the latest header
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/75711
Fixes https://github.com/llvm/llvm-project/issues/53520.
Description
Provide `intrin0.h` to be the minimal set of intrinsics that the MSVC STL
requires.
The `intrin0.h` header matches the latest
33 matches
Mail list logo
