https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
charmitro wrote:
> LGTM! Do you need someone to land this on your behalf?
I don't have commit rights. If I remember correctly from when LLVM used
Phabricator (reviews.llvm.org) you'd need my name & e-address. If that's so,
`Charalampos Mitrodimas `
https://github.com/AaronBallman approved this pull request.
LGTM! Do you need someone to land this on your behalf?
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From 0348c138e5a4295d86defbe40259105b64703d13 Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
@@ -18931,7 +18931,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
// constant evaluated
bool NeededForConstantEvaluation =
isPotentiallyConstantEvaluatedContext(*this) &&
- isImplicitlyDefinableConstexprFunction(Func);
+
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From c0ef5a06026d449aadfadca9948d148b25d1 Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From ffc6db2006ed503369ce79a6507fa237649e6af1 Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
@@ -18931,7 +18931,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
// constant evaluated
bool NeededForConstantEvaluation =
isPotentiallyConstantEvaluatedContext(*this) &&
- isImplicitlyDefinableConstexprFunction(Func);
+
@@ -18931,7 +18931,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
// constant evaluated
bool NeededForConstantEvaluation =
isPotentiallyConstantEvaluatedContext(*this) &&
- isImplicitlyDefinableConstexprFunction(Func);
+
@@ -18931,7 +18931,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
// constant evaluated
bool NeededForConstantEvaluation =
isPotentiallyConstantEvaluatedContext(*this) &&
- isImplicitlyDefinableConstexprFunction(Func);
+
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From 89eb978ece40cd99b3ac535ae25191e0edadb378 Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From 7961a90a020f6fde5c6cd892024ff0fe329450ee Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
@@ -18931,7 +18931,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
// constant evaluated
bool NeededForConstantEvaluation =
isPotentiallyConstantEvaluatedContext(*this) &&
- isImplicitlyDefinableConstexprFunction(Func);
+
@@ -18931,7 +18931,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
// constant evaluated
bool NeededForConstantEvaluation =
isPotentiallyConstantEvaluatedContext(*this) &&
- isImplicitlyDefinableConstexprFunction(Func);
+
@@ -18931,7 +18931,7 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc,
FunctionDecl *Func,
// constant evaluated
bool NeededForConstantEvaluation =
isPotentiallyConstantEvaluatedContext(*this) &&
- isImplicitlyDefinableConstexprFunction(Func);
+
https://github.com/AaronBallman approved this pull request.
Aside from a minor NFC nit with where we decide to do the check, this LGTM
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From f60f12f8e4e8b70a8fdf2aa9398b94849a863fff Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
ahatanak wrote:
Any progress on this patch?
As we discussed in https://github.com/llvm/llvm-project/issues/74016, we should
make sure clang doesn't stop emitting the warning when the definition of a pure
virtual function is actually needed.
It seems to me that we shouldn't set
https://github.com/cor3ntin approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
charmitro wrote:
> Perhaps needs a release note.
> Can you add a release note indicating #74016 was fixed? Otherwise LGTM.
Release note added.
> If you wanted to make a follow up {R to rename `isPure` to `isPureVirtual`, i
> think that might be helpful (to avoid confusion with the
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From 83d29e896b7ae0b5b259cbf179143e526dc37b1c Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
cor3ntin wrote:
Can you add a release note indicating
https://github.com/llvm/llvm-project/issues/74016 was fixed?
Otherwise LGTM.
If you wanted to make a follow up {R to rename `isPure` to `isPureVirtual`, i
think that might be helpful (to avoid confusion with the `gnu::pure` attribute)
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From 5582cfacf106a7c00912fcef0d116d6fa58e064b Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d6fbd96e5eaf3e8acbf1b43dce7a311352907567
1140e0094137614ad9917276f5324cbea4f2e0f9 --
https://github.com/charmitro edited
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4952,7 +4952,8 @@ void Sema::InstantiateFunctionDefinition(SourceLocation
PointOfInstantiation,
std::make_pair(Function, PointOfInstantiation));
} else if (TSK == TSK_ImplicitInstantiation) {
if (AtEndOfTU && !getDiagnostics().hasErrorOccurred() &&
-
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From 1140e0094137614ad9917276f5324cbea4f2e0f9 Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
@@ -4952,7 +4952,8 @@ void Sema::InstantiateFunctionDefinition(SourceLocation
PointOfInstantiation,
std::make_pair(Function, PointOfInstantiation));
} else if (TSK == TSK_ImplicitInstantiation) {
if (AtEndOfTU && !getDiagnostics().hasErrorOccurred() &&
-
@@ -4952,7 +4952,8 @@ void Sema::InstantiateFunctionDefinition(SourceLocation
PointOfInstantiation,
std::make_pair(Function, PointOfInstantiation));
} else if (TSK == TSK_ImplicitInstantiation) {
if (AtEndOfTU && !getDiagnostics().hasErrorOccurred() &&
-
@@ -0,0 +1,20 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wundefined-func-template %s
+// expected-no-diagnostics
+
+namespace PR74016 {
charmitro wrote:
Fixed. I wasn't aware of this, thanks!
https://github.com/llvm/llvm-project/pull/74510
https://github.com/charmitro updated
https://github.com/llvm/llvm-project/pull/74510
>From 0be0d65a74cf7a6a06150362b68adff122a3a39b Mon Sep 17 00:00:00 2001
From: Charalampos Mitrodimas
Date: Tue, 5 Dec 2023 11:46:56 +0200
Subject: [PATCH] [clang] Disable missing definition warning on pure
@@ -0,0 +1,20 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wundefined-func-template %s
+// expected-no-diagnostics
+
+namespace PR74016 {
Fznamznon wrote:
I think we normally call them GH when a bug was filed as a GitHub issue.
```suggestion
namespace GH74016 {
@@ -4952,7 +4952,8 @@ void Sema::InstantiateFunctionDefinition(SourceLocation
PointOfInstantiation,
std::make_pair(Function, PointOfInstantiation));
} else if (TSK == TSK_ImplicitInstantiation) {
if (AtEndOfTU && !getDiagnostics().hasErrorOccurred() &&
-
https://github.com/Fznamznon commented:
Perhaps needs a release note.
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/74510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Charalampos Mitrodimas (charmitro)
Changes
Warning '-Wundefined-func-template' incorrectly indicates that no definition is
available for a pure virtual function. However, a definition is not needed for
a pure virtual function.
Fixes
https://github.com/charmitro created
https://github.com/llvm/llvm-project/pull/74510
Warning '-Wundefined-func-template' incorrectly indicates that no definition is
available for a pure virtual function. However, a definition is not needed for
a pure virtual function.
Fixes #74016
>From
39 matches
Mail list logo
