[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/68646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

https://github.com/cor3ntin approved this pull request. I was about to work on that and figured the fix would be along those lines! Glad you got to it first, thanks! The changes look great https://github.com/llvm/llvm-project/pull/68646 ___

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

@@ -358,6 +358,8 @@ Bug Fixes in This Version Fixes (`#67690 `_) - Fixes a ``clang-17`` regression where ``LLVM_UNREACHABLE_OPTIMIZE=OFF`` cannot be used with ``Release`` mode builds. (`#68237

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68646 >From ffc9412252cd0e046978f183384375580bd31245 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 10 Oct 2023 07:52:06 +0800 Subject: [PATCH 1/3] [clang]Avoid diagnoise invalid consteval call for invalid

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/68646 >From ffc9412252cd0e046978f183384375580bd31245 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 10 Oct 2023 07:52:06 +0800 Subject: [PATCH 1/2] [clang]Avoid diagnoise invalid consteval call for invalid

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

@@ -0,0 +1,20 @@ +// RUN: %clang_cc1 -verify -std=c++20 -fsyntax-only %s + +// expected-note@+2{{candidate constructor (the implicit move constructor) not viable: no known conversion from 'int' to 'S &&' for 1st argument}} erichkeane wrote: Can you use the

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

https://github.com/erichkeane commented: Needs a release note, plus a couple nits. Otherwise LGTM! https://github.com/llvm/llvm-project/pull/68646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

@@ -0,0 +1,20 @@ +// RUN: %clang_cc1 -verify -std=c++20 -fsyntax-only %s + +// expected-note@+2{{candidate constructor (the implicit move constructor) not viable: no known conversion from 'int' to 'S &&' for 1st argument}} +// expected-note@+1{{candidate constructor (the

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

@@ -18406,9 +18406,10 @@ static void EvaluateAndDiagnoseImmediateInvocation( FD = Call->getConstructor(); else if (auto *Cast = dyn_cast(InnerExpr)) FD = dyn_cast_or_null(Cast->getConversionFunction()); - erichkeane wrote: Unrelated change.

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/68646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Congcong Cai (HerrCai0907) Changes Fixes:#68542 It is meaningless to diagnose further error for a invalid function declaration. --- Full diff: https://github.com/llvm/llvm-project/pull/68646.diff 2 Files Affected: - (modified)

[clang] [clang]Avoid diagnose invalid consteval call for invalid function decl (PR #68646)

https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/68646 Fixes:#68542 It is meaningless to diagnose further error for a invalid function declaration. >From ffc9412252cd0e046978f183384375580bd31245 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 10 Oct 2023