[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
felipepiovezan wrote: > > This seems akin to running clang-format on the entire project, which last > > time we talked about still faced opposition > > My impression (I admit I haven't reviewed the whole thread lately) is that > the opposition has mostly to do with how clang-format mangles some > constructs, not to the idea in general. > > I'm juggling 4 projects at the moment, I have to finish some internal > release-related work before I can get back to clang-format-all-the-things. Sorry, you might be right; my intent with that comment was not to a make broad summary of the thread, but rather to point out the thread's existence and that this PR should probably be folded into that discussion. https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
pogo59 wrote: > This seems akin to running clang-format on the entire project, which last > time we talked about still faced opposition My impression (I admit I haven't reviewed the whole thread lately) is that the opposition has mostly to do with how clang-format mangles some constructs, not to the idea in general. I'm juggling 4 projects at the moment, I have to finish some internal release-related work before I can get back to clang-format-all-the-things. https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
dwblaikie wrote: The dev policy says "Avoid committing formatting- or whitespace-only changes outside of code you plan to make subsequent changes to." - I think it's reasonable to consider changing this, but probably under the "clang-format everything" or a similar discussion (broad discussion before we worry about making pull requests https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
jrtc27 wrote: Also this is the kind of commit that should really be done by a core trusted member of the community. It's way too easy to hide something nefarious (not that I'm accusing you of that, just that we always need to be vigilant) in an 8k+ diff, and it's not much fun to review that code. Also it's best when people provide the scripts used to do these kinds of mass changes; that (a) lets people verify what you did by auditing the script and running it themselves (b) lets downstreams easily perform the same change on their forks. The fact that this is a +8347 -8382 diff also confuses me; I would expect the number of lines to remain constant, but maybe you're including trailing blank lines as trailing whitespace?.. https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
arichardson wrote: This will cause huge merge conflicts for all downstreams. While they are easy to resolve it can be quite annoying. I think we should just do this as part of the global clang-format. https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
felipepiovezan wrote: Juuust to make sure, was this discussed before? This seems akin to running clang-format on the entire project, which last time we talked about still faced opposition: https://discourse.llvm.org/t/rfc-clang-format-all-the-things/76614/11 https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
joker-eph wrote: Fine with me if we want to land this as is, but per-top-level subproject may be a better granularity. https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it) for more information. https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
AtariDreams wrote: I'm just gonna split this up. Sorry. https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
https://github.com/AtariDreams closed https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)
llvmbot wrote: @llvm/pr-subscribers-backend-arm @llvm/pr-subscribers-clang Author: AtariDreams (AtariDreams) Changes Every once in a while, some formatting scanner will cause the CI to stop because of whitespace issues, so it is is best to just remove them in one go, especially since it seems only non-test files tend to be under scrutiny by automatic formatting checkers. --- Patch is 2.04 MiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/82838.diff 599 Files Affected: - (modified) .github/workflows/scorecard.yml (+2-2) - (modified) clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.h (+1-1) - (modified) clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.cpp (+10-10) - (modified) clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.h (+2-2) - (modified) clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp (+2-2) - (modified) clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.h (+1-1) - (modified) clang-tools-extra/clang-tidy/bugprone/SpuriouslyWakeUpFunctionsCheck.h (+3-3) - (modified) clang-tools-extra/clang-tidy/fuchsia/StaticallyConstructedObjectsCheck.h (+1-1) - (modified) clang-tools-extra/clang-tidy/fuchsia/TrailingReturnCheck.h (+2-2) - (modified) clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp (+1-1) - (modified) clang-tools-extra/clang-tidy/misc/ConfusableTable/confusables.txt (+4701-4701) - (modified) clang-tools-extra/clangd/ClangdLSPServer.h (+1-1) - (modified) clang-tools-extra/clangd/CodeComplete.cpp (+2-2) - (modified) clang-tools-extra/clangd/IncludeCleaner.cpp (+3-3) - (modified) clang-tools-extra/clangd/Protocol.h (+2-2) - (modified) clang-tools-extra/clangd/quality/CompletionModel.cmake (+2-2) - (modified) clang-tools-extra/clangd/quality/README.md (+8-8) - (modified) clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp (+1-1) - (modified) clang-tools-extra/clangd/test/Inputs/symbols.test.yaml (+4-4) - (modified) clang-tools-extra/clangd/tool/Check.cpp (+1-1) - (modified) clang-tools-extra/docs/clang-tidy/checks/bugprone/assignment-in-if-condition.rst (+1-1) - (modified) clang-tools-extra/docs/clang-tidy/checks/bugprone/signal-handler.rst (+1-1) - (modified) clang-tools-extra/docs/clang-tidy/checks/bugprone/suspicious-realloc-usage.rst (+1-1) - (modified) clang-tools-extra/docs/clang-tidy/checks/misc/include-cleaner.rst (+2-2) - (modified) clang-tools-extra/docs/clang-tidy/checks/modernize/type-traits.rst (+1-1) - (modified) clang-tools-extra/docs/clang-tidy/checks/objc/nsdate-formatter.rst (+26-26) - (modified) clang-tools-extra/docs/clang-tidy/checks/readability/redundant-inline-specifier.rst (+1-1) - (modified) clang-tools-extra/pseudo/Disambiguation.md (+3-3) - (modified) clang-tools-extra/pseudo/gen/Main.cpp (+1-1) - (modified) clang/docs/HLSL/ExpectedDifferences.rst (+2-2) - (modified) clang/examples/PrintFunctionNames/PrintFunctionNames.cpp (+1-1) - (modified) clang/tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs (+4-3) - (modified) clang/tools/clang-format-vs/ClangFormat/RunningDocTableEventsDispatcher.cs (+1-1) - (modified) clang/tools/clang-fuzzer/CMakeLists.txt (+1-1) - (modified) clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp (+1-1) - (modified) clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp (+2-2) - (modified) clang/tools/clang-linker-wrapper/LinkerWrapperOpts.td (+2-2) - (modified) clang/tools/clang-offload-packager/CMakeLists.txt (+1-1) - (modified) clang/tools/diagtool/DiagTool.cpp (+3-3) - (modified) clang/tools/diagtool/DiagTool.h (+7-7) - (modified) clang/tools/diagtool/diagtool_main.cpp (+1-1) - (modified) clang/tools/libclang/ARCMigrate.cpp (-1) - (modified) clang/tools/libclang/CIndexCXX.cpp (+13-13) - (modified) clang/tools/libclang/CIndexCodeCompletion.cpp (+42-48) - (modified) clang/tools/libclang/CIndexDiagnostic.cpp (+22-22) - (modified) clang/tools/libclang/CIndexDiagnostic.h (+13-13) - (modified) clang/tools/libclang/CIndexHigh.cpp (+4-4) - (modified) clang/tools/libclang/CIndexer.h (+1-1) - (modified) clang/tools/libclang/CXIndexDataConsumer.cpp (+16-16) - (modified) clang/tools/libclang/CXIndexDataConsumer.h (+4-4) - (modified) clang/tools/libclang/CXLoadedDiagnostic.cpp (+10-11) - (modified) clang/tools/libclang/CXLoadedDiagnostic.h (+3-3) - (modified) clang/tools/libclang/CXSourceLocation.cpp (+19-20) - (modified) clang/tools/libclang/CXSourceLocation.h (+4-4) - (modified) clang/tools/libclang/CXStoredDiagnostic.cpp (+6-7) - (modified) clang/tools/libclang/CXTranslationUnit.h (+1-1) - (modified) clang/tools/libclang/CXType.cpp (+10-10) - (modified) clang/tools/libclang/CXType.h (+1-2) - (modified) clang/tools/libclang/Index_Internal.h (+1-1) - (modified) clang/tools/libclang/Indexing.cpp (+7-7) - (modified) clang/tools/scan-build-py/README.md (+6-6) - (modified) clang/tools/scan-build/bin/scan-build (+1-1) - (modified)
