[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > When I install Visual Studio, it creates a widget that brings up a cmd shell > with the right environment. I'm not aware of a similar widget for PowerShell. At least in VS 2022, there is a `Developer PowerShell for VS 2022` in Start menu beside the usual `x64 Native Tools

[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Paul T Robinson via cfe-commits
pogo59 wrote: I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to use on Windows. (When I install Visual Studio, it creates a widget that brings up a `cmd` shell with the right environment. I'm not aware of a similar widget for PowerShell.) While I rarely try to

[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-07 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: > I think that might be a bit too accelerated. I work mostly with a fork of > LLVM (https://github.com/apple/llvm-project) and do care about the usability > of `cmd` as a shell (however, it is significantly behind but is working on > updating to a more recent version). I

[clang] [lit] Are all RUN lines skipped in windows cmd? (PR #65242)

2023-09-05 Thread Joel E. Denny via cfe-commits
jdenny-ornl wrote: Thanks for everyone's comments so far. This PR is not ready to land. As discussed, it doesn't fully fix support for windows `cmd` as a lit external shell. Given how long that use case has been broken (apparently since April, 2022), it seems that's a use case no one cares