jmorse wrote:
Several decades later; I applied this check to the verifier and reduced around
it:
```
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index b1cf81a3dbdc..9e2250b584b1 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -1421,6 +1421,9 @@ void
jmorse wrote:
```
https://github.com/llvm/llvm-project/pull/75385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dzhidzhoev wrote:
> I see what you're saying about the metadata being incorrect; I feel like I've
> seen it before, but can't pin it down. For the record, all the builds where
> we saw this assertion were thin/full LTO.
>
> I've kicked off a reduction of a large reproducer that I have to
jmorse wrote:
I see what you're saying about the metadata being incorrect; I feel like I've
seen it before, but can't pin it down. For the record, all the builds where we
saw this assertion were thin/full LTO.
I've kicked off a reduction of a large reproducer that I have to hand; I'm not
dzhidzhoev wrote:
> ...ah, actually is it malformed because there's a DICompositeType in the
> retainedNodes list for a DISubprogram? I remember that the verifier
> considered that illegal before your patch landed, but not after.
Having this commit applied, DICompositeTypes with the scope of
dzhidzhoev wrote:
> Hmmm, that's unexpected -- I reverted the revert (tree here, contains one
> unrelated commit:
> https://github.com/jmorse/llvm-project/tree/reapply-localvars-patch) and
> rebuilt. The assertion-failure occurs just with `llc foobar.ll -o out.o
> -filetype=obj`, where
dcci wrote:
Reverted in
https://github.com/llvm/llvm-project/commit/b6f922fbf5e983122271aa12acb33f6172046d4d
https://github.com/llvm/llvm-project/pull/75385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/75385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/75385
>From 2953d4adcb36c28d12a3e3f8febf0995ef22c0d9 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Tue, 18 Jul 2023 14:22:46 +0200
Subject: [PATCH] [DebugMetadata][DwarfDebug] Support function-local
https://github.com/dwblaikie approved this pull request.
Yeah, looks OK to me - sorry for the delay.
https://github.com/llvm/llvm-project/pull/75385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dzhidzhoev wrote:
@dwblaikie
Could you please take a look at this when you have a chance?
https://github.com/llvm/llvm-project/pull/75385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/adrian-prantl commented:
I think this LGTM, but it would be good if someone else also took a look.
https://github.com/llvm/llvm-project/pull/75385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -238,6 +238,13 @@ void llvm::CloneFunctionInto(Function *NewFunc, const
Function *OldFunc,
}
}
+// Avoid cloning local variables of subprograms that won't be cloned.
adrian-prantl wrote:
Can you add a sentence explaining why some
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 930b5b52ffe699dbcf05eea32d12a2861dd2bdf6
e7c3389385ddbc9cedeb2869305fa672d3b9c427 --
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
@llvm/pr-subscribers-clang
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
- [DebugMetadata][DwarfDebug] Support function-local types in lexical block
scopes (4/7)
- [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined
15 matches
Mail list logo
