[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

https://github.com/ributzka closed https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

ributzka wrote: Thanks for the reviews. Checks are good now too after rebase. https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

https://github.com/ributzka updated https://github.com/llvm/llvm-project/pull/69262 >From ceaf58ba2f752b8a5353568013ff18603b0e615b Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Mon, 28 Aug 2023 15:25:48 -0700 Subject: [PATCH] [llvm] Use XMACROS for MachO platforms. This change adds

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

ributzka wrote: Unrelated build issue on windows: C:\ws\src\mlir\include\mlir/IR/BuiltinTypeInterfaces.h(14): fatal error C1083: Cannot open include file: 'mlir/IR/BuiltinTypeInterfaces.h.inc': No such file or directory https://github.com/llvm/llvm-project/pull/69262

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

https://github.com/ributzka updated https://github.com/llvm/llvm-project/pull/69262 >From d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Mon, 28 Aug 2023 15:25:48 -0700 Subject: [PATCH 1/3] [llvm] Use XMACROS for MachO platforms. This change

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

https://github.com/JDevlieghere approved this pull request. I like how this centralizes everything in a single place and the def file format seems like a natural fit for the platforms. https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

https://github.com/ributzka updated https://github.com/llvm/llvm-project/pull/69262 >From d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Mon, 28 Aug 2023 15:25:48 -0700 Subject: [PATCH 1/2] [llvm] Use XMACROS for MachO platforms. This change

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b225934a4b0d2944958a53269665b00e7eae4875 d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 --

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

https://github.com/dcci approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Juergen Ributzka (ributzka) Changes This change adds the PLATFORM XMACRO to simplify the addition of new MachO platforms and reduce the number of required changes. Many of the changes needed for adding a new platform are

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

https://github.com/ributzka created https://github.com/llvm/llvm-project/pull/69262 This change adds the PLATFORM XMACRO to simplify the addition of new MachO platforms and reduce the number of required changes. Many of the changes needed for adding a new platform are mechanical, such as adding