Re: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

2019-12-30 Thread Alexander Kornienko via cfe-commits
Any news here? The problem is still there. On Fri, Dec 13, 2019 at 12:33 AM Andrews, Elizabeth < elizabeth.andr...@intel.com> wrote: > Hi Alexander, > > > > I am debugging this now but I assume the checks for the if condition were > skipped before this commit (therefore no crash) because ‘c’ was

RE: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

2019-12-12 Thread Andrews, Elizabeth via cfe-commits
Hi Alexander, I am debugging this now but I assume the checks for the if condition were skipped before this commit (therefore no crash) because ‘c’ was set as type dependent. The checks are probably run now since c’s type dependency changed with this patch. The checks might need to be guarded

Re: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

2019-12-11 Thread Alexander Kornienko via cfe-commits
After this commit clang started generating assertion failures on valid code. There are tons of instances in our codebase. Here's a reduced test case: template class a { int c : b; void f() { if (c) ; } }; Please take a look. On Wed, Dec 4, 2019 at 12:39 AM Elizabeth Andrews via

[clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

2019-12-03 Thread Elizabeth Andrews via cfe-commits
Author: Elizabeth Andrews Date: 2019-12-03T15:27:19-08:00 New Revision: 878a24ee244a24c39d1c57e9af2e88c621f7cce9 URL: https://github.com/llvm/llvm-project/commit/878a24ee244a24c39d1c57e9af2e88c621f7cce9 DIFF: