@@ -103,6 +103,13 @@ function (gen_rst_file_from_td output_file td_option
source docs_targets)
endfunction()
if (LLVM_ENABLE_SPHINX)
+ llvm_find_program(dot)
vgvassilev wrote:
@Krishna-13-cyber, could we drop the `llvm_find_program(dot)` and rely on
vgvassilev wrote:
@Krishna-13-cyber, could you implement the suggestion and we can try to
recommit the code.
https://github.com/llvm/llvm-project/pull/65650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nikic wrote:
You probably should just use find_program instead of llvm_find_program. It
looks like llvm_find_program is used in just a single place, while we have very
wide direct use of find_program, so I'm not sure why it is a thing in the first
place.
@@ -213,6 +213,411 @@ concept helps support advanced use cases such as template
instantiations on dema
automatic language interoperability. It also helps static languages such as
C/C++ become
apt for data science.
+Execution Results Handling in Clang-Repl
@@ -213,6 +213,411 @@ concept helps support advanced use cases such as template
instantiations on dema
automatic language interoperability. It also helps static languages such as
C/C++ become
apt for data science.
+Execution Results Handling in Clang-Repl
vgvassilev wrote:
> Actually no, that's not possible as config-ix modules are explicitly private
> to their subproject and should not be used outside them. I'm going to revert
> this change due to this layering violation.
@nikic, can you suggest a particular fix? We saw this approach was done
@@ -213,6 +213,411 @@ concept helps support advanced use cases such as template
instantiations on dema
automatic language interoperability. It also helps static languages such as
C/C++ become
apt for data science.
+Execution Results Handling in Clang-Repl
nikic wrote:
Actually no, that's not possible as config-ix modules are explicitly private to
their subproject and should not be used outside them. I'm going to revert this
change due to this layering violation.
https://github.com/llvm/llvm-project/pull/65650
nikic wrote:
This also breaks the clang standalone build. You need to `include(config-ix)`
in order to use `llvm_find_program`.
https://github.com/llvm/llvm-project/pull/65650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
AaronBallman wrote:
> @AaronBallman, we need to install dot/doxygen on this machine as Sphinx
> requires graphviz. The PR has a link to the discussion and we could not find
> the bot owners.
Ouch, we've struggled recently to get the attention of the sphinx bot owners.
:-(
The publication
vgvassilev wrote:
@AaronBallman, we need to install dot/doxygen on this machine as Sphinx
requires graphviz. The PR has a link to the discussion and we could not find
the bot owners.
https://github.com/llvm/llvm-project/pull/65650
___
cfe-commits
AaronBallman wrote:
This appears to have broken the clang-tools-extra Sphinx bot:
https://lab.llvm.org/buildbot/#/builders/115/builds/54901
```
CMake Error at
/home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/src/clang/docs/CMakeLists.txt:110
(message):
Cannot find DOT
```
https://github.com/vgvassilev closed
https://github.com/llvm/llvm-project/pull/65650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev approved this pull request.
LGTM! Let's move forward.
https://github.com/llvm/llvm-project/pull/65650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Krishna-13-cyber updated
https://github.com/llvm/llvm-project/pull/65650
>From b14c1890e4d5ecf4ebd9d0aefe9f73a0b3a12f5f Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber
Date: Thu, 7 Sep 2023 22:35:53 +0530
Subject: [PATCH] Add Documentation for Execution Results Handling in
https://github.com/Krishna-13-cyber updated
https://github.com/llvm/llvm-project/pull/65650
>From 967d465083c2bf0887be14380b82aac69175b47e Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber
Date: Thu, 7 Sep 2023 22:35:53 +0530
Subject: [PATCH 1/2] Add Documentation for Execution Results Handling
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
b6f6fe98a856e9ce8ab945ef18d49291a8486acc..001c8fe5627bb83c71a11535889d3c717a869df5
https://github.com/Krishna-13-cyber updated
https://github.com/llvm/llvm-project/pull/65650
>From 001c8fe5627bb83c71a11535889d3c717a869df5 Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber
Date: Thu, 7 Sep 2023 22:35:53 +0530
Subject: [PATCH] Add Documentation for Execution Results Handling in
https://github.com/Krishna-13-cyber updated
https://github.com/llvm/llvm-project/pull/65650
>From 63b41d9498a71e090cbf1fdca2d87f368aeb809c Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber
Date: Thu, 7 Sep 2023 22:35:53 +0530
Subject: [PATCH 1/2] Add Documentation for Execution Results Handling
https://github.com/Krishna-13-cyber updated
https://github.com/llvm/llvm-project/pull/65650
>From 145ff3877b588aebd811f26b6d596257ea889957 Mon Sep 17 00:00:00 2001
From: Krishna-13-cyber
Date: Thu, 7 Sep 2023 22:35:53 +0530
Subject: [PATCH 1/2] Add Documentation for Execution Results Handling
vgvassilev wrote:
@Krishna-13-cyber, can you rebase this PR?
@gribozavr ping.
https://github.com/llvm/llvm-project/pull/65650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -213,6 +213,411 @@ concept helps support advanced use cases such as template
instantiations on dema
automatic language interoperability. It also helps static languages such as
C/C++ become
apt for data science.
+Execution Results Handling in Clang-Repl
@@ -213,6 +213,411 @@ concept helps support advanced use cases such as template
instantiations on dema
automatic language interoperability. It also helps static languages such as
C/C++ become
apt for data science.
+Execution Results Handling in Clang-Repl
Krishna-13-cyber wrote:
Ping.
https://github.com/llvm/llvm-project/pull/65650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vgvassilev wrote:
@gribozavr, after this PR we will need to have `dot` for the sphinx
documentation for the bots. Could you install it on the bots? Eg,
https://lab.llvm.org/buildbot/#/builders/92/builds/49520
Further details:
https://github.com/vgvassilev review_requested
https://github.com/llvm/llvm-project/pull/65650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Krishna-13-cyber review_requested
https://github.com/llvm/llvm-project/pull/65650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Krishna-13-cyber created
https://github.com/llvm/llvm-project/pull/65650:
[clang-repl] Add Documentation for Execution Results Handling.
This patch adds documentation for execution results handling in Clang-REPL with
the below features:
- Automatic Printf feature
- Value
28 matches
Mail list logo
