https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922
>From 8aa439a97a56ef80bfc9ccc90a9f093680e455f5 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Sun, 22 Oct 2023 11:11:53 +0200
Subject: [PATCH 1/3] rebase...
---
clang/docs/ReleaseNotes.rst
ilya-biryukov wrote:
Oh, one last thing! @usx95 maybe add a test for the visibility check?
Various tests with modules (search for files with the `.cppm` extension in the
tests) should give a good starting point.
https://github.com/llvm/llvm-project/pull/68922
https://github.com/ilya-biryukov approved this pull request.
https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema , SourceLocation
OpLoc,
return true;
}
// Otherwise the search scope is the namespace scope of which F is a member.
- LookupResult NonMembers(S, NotEqOp, OpLoc,
-
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema , SourceLocation
OpLoc,
return true;
}
// Otherwise the search scope is the namespace scope of which F is a member.
- LookupResult NonMembers(S, NotEqOp, OpLoc,
-
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922
>From 8aa439a97a56ef80bfc9ccc90a9f093680e455f5 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Sun, 22 Oct 2023 11:11:53 +0200
Subject: [PATCH 1/2] rebase...
---
clang/docs/ReleaseNotes.rst
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema , SourceLocation
OpLoc,
return true;
}
// Otherwise the search scope is the namespace scope of which F is a member.
- LookupResult NonMembers(S, NotEqOp, OpLoc,
-
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922
>From 8aa439a97a56ef80bfc9ccc90a9f093680e455f5 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Sun, 22 Oct 2023 11:11:53 +0200
Subject: [PATCH] rebase...
---
clang/docs/ReleaseNotes.rst | 4
https://github.com/usx95 reopened
https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922
>From 0c71b6bdd557ff4b9ad9a4ec4f0919e3460596b0 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Thu, 12 Oct 2023 21:35:52 +0200
Subject: [PATCH 1/5] Find opertor!= in the correct namespace
---
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema , SourceLocation
OpLoc,
return true;
}
// Otherwise the search scope is the namespace scope of which F is a member.
- LookupResult NonMembers(S, NotEqOp, OpLoc,
-
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema , SourceLocation
OpLoc,
return true;
}
// Otherwise the search scope is the namespace scope of which F is a member.
- LookupResult NonMembers(S, NotEqOp, OpLoc,
-
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema , SourceLocation
OpLoc,
return true;
}
// Otherwise the search scope is the namespace scope of which F is a member.
- LookupResult NonMembers(S, NotEqOp, OpLoc,
-
https://github.com/ilya-biryukov requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922
>From 0c71b6bdd557ff4b9ad9a4ec4f0919e3460596b0 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Thu, 12 Oct 2023 21:35:52 +0200
Subject: [PATCH 1/4] Find opertor!= in the correct namespace
---
usx95 wrote:
Thanks @zygoloid.
This case was failing with my change. Corrected and added tests.
https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zygoloid wrote:
> > Does this work for function-scope operator declarations?
>
> @zygoloid I am not sure I follow. Could you please give an example.
Sure:
```c++
struct X { operator int(); };
bool f(X x) {
bool operator==(X, int);
return x == x;
}
bool g(X x) {
bool operator==(X,
usx95 wrote:
> Does this work for function-scope operator declarations?
@zygoloid I am not sure I follow. Could you please give an example. If this is
about member operator, the search scope is class scope of the first operand.
https://github.com/llvm/llvm-project/pull/68922
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922
>From 0c71b6bdd557ff4b9ad9a4ec4f0919e3460596b0 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Thu, 12 Oct 2023 21:35:52 +0200
Subject: [PATCH 1/3] Find opertor!= in the correct namespace
---
https://github.com/cor3ntin commented:
Looks reasonable, but i found a typo
https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -64,6 +64,10 @@ C/C++ Language Potentially Breaking Changes
``__has_c_attribute(warn_unused_result)``, 202003, 0
``__has_c_attribute(gnu::warn_unused_result)``, 202003, 1
+- Fixed a bug in finding matching `operator!=` while adding reveresed
zygoloid wrote:
Does this work for function-scope operator declarations?
https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922
>From 0c71b6bdd557ff4b9ad9a4ec4f0919e3460596b0 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Thu, 12 Oct 2023 21:35:52 +0200
Subject: [PATCH 1/2] Find opertor!= in the correct namespace
---
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Utkarsh Saxena (usx95)
Changes
`S.getScopeForContext` determins the **active** scope associated with the given
`declContext`.
This fails to find the matching `operator!=` if candidate `operator==` was
found via ADL since that scope is
https://github.com/usx95 ready_for_review
https://github.com/llvm/llvm-project/pull/68922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/68922
`S.getScopeForContext` determins the **active** scope associated with the given
`declContext`.
This fails to find the matching `operator!=` if candidate `operator==` was
found via ADL since that scope is not
31 matches
Mail list logo
