Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

2020-03-21 Thread David Blaikie via cfe-commits
Probably worth a bit more detail when recommitting a patch that was reverted - in the future please include more detail about the reason for the original revert and the specific changes to the previous version that address that (so someone who might've reviewed the previous patch can more quickly e

Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

2020-02-26 Thread Blower, Melanie I via cfe-commits
gt; Today's Topics: > >1. [PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit > permutation & table lookup > (Eli Friedman via Phabricator via cfe-commits) >2. Re: [clang] abd0905

Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

2020-02-25 Thread Rumeet Dhindsa via cfe-commits
Hi, I saw that this patch was reverted again later, but wanted to let you know the performance impact we saw with this patch. We are testing this on a variety of x86 machines and saw across the board regressions in Eigen of around 25-50%, changing no compile time options. Thanks, Rumeet On Wed,

[clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

2020-02-12 Thread Melanie Blower via cfe-commits
Author: Melanie Blower Date: 2020-02-12T07:30:43-08:00 New Revision: abd09053bc7aa6144873c196a7d50aa6ce6ca430 URL: https://github.com/llvm/llvm-project/commit/abd09053bc7aa6144873c196a7d50aa6ce6ca430 DIFF: https://github.com/llvm/llvm-project/commit/abd09053bc7aa6144873c196a7d50aa6ce6ca430.diff