Re: [clang] e5c7c17 - [clang] Rename StringRef _lower() method calls to _insensitive()

2021-06-28 Thread David Blaikie via cfe-commits
Ah, found it in https://reviews.llvm.org/D104819 - good to leave that in in the "Differential Revision: " part of the commit message (or if you end up splitting patches off from a review, such that it doesn't necessarily make sense for it to close the review (preparatory patches, etc) then linking

Re: [clang] e5c7c17 - [clang] Rename StringRef _lower() method calls to _insensitive()

2021-06-28 Thread David Blaikie via cfe-commits
Was this design/code reviewed (there's no mention in the commit message of a link to a phab review, for instance)? Probably worth some discussion - if there was a review, could you link it here in a reply? On Thu, Jun 24, 2021 at 2:23 PM Martin Storsjö via cfe-commits <

[clang] e5c7c17 - [clang] Rename StringRef _lower() method calls to _insensitive()

2021-06-24 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-06-25T00:22:01+03:00 New Revision: e5c7c171e5db6af1e3dca1059df4287b0d147eaf URL: https://github.com/llvm/llvm-project/commit/e5c7c171e5db6af1e3dca1059df4287b0d147eaf DIFF: