@@ -180,3 +180,44 @@ void std_forward_rvalue_ref_safe(absl::optional&&
opt) {
std::forward>(opt).value();
}
+
+namespace std {
+
+template
+class optional {
+public:
+ template
+ optional& operator=(const U ){
+ data = u;
+ }
+private:
+ T
https://github.com/ymand requested changes to this pull request.
Thanks for this fix! Unfortunately, I wasn't able to repro the crash in
godbolt: https://godbolt.org/z/s741z5djY. Can you double check that the check
crashes on that example without your fix?
@@ -180,3 +180,44 @@ void std_forward_rvalue_ref_safe(absl::optional&&
opt) {
std::forward>(opt).value();
}
+
+namespace std {
+
+template
+class optional {
+public:
+ template
+ optional& operator=(const U ){
+ data = u;
+ }
+private:
+ T
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/68510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/68510
>From eb9f8342821048edefaefd038bdd989853ac69a3 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 8 Oct 2023 16:00:29 +0800
Subject: [PATCH] [clang][analysis]Use dyn_cast_or_null instead cast to prevent
crash
jcsxky wrote:
> LGTM, When release notes could be nice
> (clang-tools-extra/doc/ReleaseNotest.rst) with something like: `Improved
> bugprone-unchecked-optional-acces check to not crash during handling of
> optional values` or `to not crash i certain situations` it may also not be so
>
@@ -202,6 +202,10 @@ Changes in existing checks
` check, so that it does not
warn on macros starting with underscore and lowercase letter.
+- Improved :doc:`bugprone-unchecked-optional-access
+ ` check, use
`cast_or_null`
+ instead `cast` so that it does not crash
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/68510
>From 466b612ff055ff7497c9473b38b90bc849370b21 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 8 Oct 2023 16:00:29 +0800
Subject: [PATCH] [clang][analysis]Use dyn_cast_or_null instead cast to prevent
crash
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/68510
>From 38cf358039d81fb3703885db082b64e11760c5fc Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 8 Oct 2023 16:00:29 +0800
Subject: [PATCH] [clang][analysis]Use dyn_cast_or_null instead cast to prevent
crash
https://github.com/PiotrZSL approved this pull request.
LGTM,
When release notes could be nice (clang-tools-extra/doc/ReleaseNotest.rst) with
something like: `Improved bugprone-unchecked-optional-acces check to not crash
during handling of optional values` or `to not crash i certain
10 matches
Mail list logo
