https://github.com/unterumarmung closed
https://github.com/llvm/llvm-project/pull/78630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
unterumarmung wrote:
The Windows build in the CI is stuck. The change is pretty trivial and doesn't
use any features that cannot be found in C++98. So, we can skip the Windows
check.
https://github.com/llvm/llvm-project/pull/78630
___
cfe-commits
https://github.com/HerrCai0907 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/78630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/unterumarmung updated
https://github.com/llvm/llvm-project/pull/78630
>From 1951badf6ba8302da1431747412edf960f53b0b1 Mon Sep 17 00:00:00 2001
From: Daniil Dudkin
Date: Fri, 19 Jan 2024 00:41:03 +0300
Subject: [PATCH] [clang-apply-replacements] Deduplicate Implementation of
https://github.com/PiotrZSL approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/78630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
unterumarmung wrote:
I honestly don't who should review/approve this, but hopefully the change is
not complicated.
https://github.com/llvm/llvm-project/pull/78630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/unterumarmung created
https://github.com/llvm/llvm-project/pull/78630
* Convert `collectReplacementsFromDirectory` into a function template.
* Employ explicit specialization to maintain implementation in the source file.
* Utilize the function template in the source file to
