https://github.com/gchatelet closed
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18,32 +18,32 @@ const static StringRef RequiredNamespaceStart =
"__llvm_libc";
const static StringRef RequiredNamespaceMacroName = "LIBC_NAMESPACE";
void ImplementationInNamespaceCheck::registerMatchers(MatchFinder *Finder) {
- Finder->addMatcher(
-
https://github.com/gchatelet updated
https://github.com/llvm/llvm-project/pull/66504
>From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet
Date: Fri, 15 Sep 2023 12:34:17 +
Subject: [PATCH 1/6] [clang-tidy] Update
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL resolved
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18,32 +18,32 @@ const static StringRef RequiredNamespaceStart =
"__llvm_libc";
const static StringRef RequiredNamespaceMacroName = "LIBC_NAMESPACE";
void ImplementationInNamespaceCheck::registerMatchers(MatchFinder *Finder) {
- Finder->addMatcher(
-
@@ -18,32 +18,32 @@ const static StringRef RequiredNamespaceStart =
"__llvm_libc";
const static StringRef RequiredNamespaceMacroName = "LIBC_NAMESPACE";
void ImplementationInNamespaceCheck::registerMatchers(MatchFinder *Finder) {
- Finder->addMatcher(
-
gchatelet wrote:
> As a single small change to make hardcoded namespaces configurable looks
> fine. I added some comments related to overall issues in this check. Fell
> free to fix them or ignore them.
Thx for the review! I had to restructure the code a bit to accommodate for
anonymous
@@ -30,15 +32,18 @@ void ImplementationInNamespaceCheck::check(
return;
gchatelet wrote:
Done
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -3,18 +3,18 @@
#define MACRO_A "defining macros outside namespace is valid"
class ClassB;
-// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
within the '__llvm_libc' namespace
+// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
https://github.com/gchatelet updated
https://github.com/llvm/llvm-project/pull/66504
>From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet
Date: Fri, 15 Sep 2023 12:34:17 +
Subject: [PATCH 1/5] [clang-tidy] Update
@@ -30,15 +32,18 @@ void ImplementationInNamespaceCheck::check(
return;
if (const auto *NS = dyn_cast(MatchedDecl)) {
-if (NS->getName() != RequiredNamespace) {
- diag(NS->getLocation(), "'%0' needs to be the outermost namespace")
- <<
https://github.com/gchatelet updated
https://github.com/llvm/llvm-project/pull/66504
>From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet
Date: Fri, 15 Sep 2023 12:34:17 +
Subject: [PATCH 1/4] [clang-tidy] Update
https://github.com/PiotrZSL approved this pull request.
As a single small change to make hardcoded namespaces configurable looks fine.
I added some comments related to overall issues in this check.
Fell free to fix them or ignore them.
https://github.com/llvm/llvm-project/pull/66504
@@ -14,7 +14,9 @@ using namespace clang::ast_matchers;
namespace clang::tidy::llvm_libc {
-const static StringRef RequiredNamespace = "__llvm_libc";
+const static StringRef RequiredNamespaceStart = "__llvm_libc";
+const static StringRef RequiredNamespaceMacroName =
@@ -30,15 +32,18 @@ void ImplementationInNamespaceCheck::check(
return;
PiotrZSL wrote:
this could be replaced with `decl(isExpansionInMainFile())`
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits
@@ -3,18 +3,18 @@
#define MACRO_A "defining macros outside namespace is valid"
class ClassB;
-// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
within the '__llvm_libc' namespace
+// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
@@ -3,18 +3,18 @@
#define MACRO_A "defining macros outside namespace is valid"
class ClassB;
-// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
within the '__llvm_libc' namespace
+// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: declaration must be declared
@@ -30,15 +32,18 @@ void ImplementationInNamespaceCheck::check(
return;
if (const auto *NS = dyn_cast(MatchedDecl)) {
-if (NS->getName() != RequiredNamespace) {
- diag(NS->getLocation(), "'%0' needs to be the outermost namespace")
- <<
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -30,15 +32,18 @@ void ImplementationInNamespaceCheck::check(
return;
if (const auto *NS = dyn_cast(MatchedDecl)) {
-if (NS->getName() != RequiredNamespace) {
- diag(NS->getLocation(), "'%0' needs to be the outermost namespace")
- <<
@@ -300,6 +300,11 @@ Changes in existing checks
` check to
identify calls to static member functions with out-of-class inline
definitions.
+- Updated :doc:`llvmlibc-implementation-in-namespace
PiotrZSL wrote:
Put changes in alphabetical order. use
https://github.com/gchatelet updated
https://github.com/llvm/llvm-project/pull/66504
>From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet
Date: Fri, 15 Sep 2023 12:34:17 +
Subject: [PATCH 1/3] [clang-tidy] Update
PiotrZSL wrote:
> Where would that be? `clang-tools-extra/docs/ReleaseNotes.rst`? I can't find
> what the current release notes look like for head.
Yes, it's deployed here: https://clang.llvm.org/extra/ReleaseNotes.html
https://github.com/llvm/llvm-project/pull/66504
gchatelet wrote:
> Should this change be reflected in the Release Notes?
Where would that be? `clang-tools-extra/docs/ReleaseNotes.rst`?
I can't find what the current release notes look like for head.
https://github.com/llvm/llvm-project/pull/66504
https://github.com/gchatelet updated
https://github.com/llvm/llvm-project/pull/66504
>From f1427a81c4a3425c1a574316fc26d2c74297b34b Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet
Date: Fri, 15 Sep 2023 12:34:17 +
Subject: [PATCH 1/2] [clang-tidy] Update
https://github.com/carlosgalvezp commented:
Should this change be reflected in the Release Notes?
https://github.com/llvm/llvm-project/pull/66504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -29,16 +31,19 @@ void ImplementationInNamespaceCheck::check(
if (!Result.SourceManager->isInMainFile(MatchedDecl->getLocation()))
return;
- if (const auto *NS = dyn_cast(MatchedDecl)) {
-if (NS->getName() != RequiredNamespace) {
- diag(NS->getLocation(),
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Changes
This is the implementation of step 3 of
https://discourse.llvm.org/t/rfc-customizable-namespace-to-allow-testing-the-libc-when-the-system-libc-is-also-llvms-libc/73079.
--
Full diff:
https://github.com/gchatelet created
https://github.com/llvm/llvm-project/pull/66504
This is the implementation of step 3 of
https://discourse.llvm.org/t/rfc-customizable-namespace-to-allow-testing-the-libc-when-the-system-libc-is-also-llvms-libc/73079.
>From
39 matches
Mail list logo
