[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2024-04-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: @twmht To my knowledge, clang and clangd have only ever supported the `@file.rsp` response file syntax. The commands in the linked thread use the `--options-file file.rsp` syntax, which clang and clangd do not support. https://github.com/clangd/vscode-clangd/issues/592

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2024-04-26 Thread via cfe-commits
twmht wrote: @HighCommander4 can you have a look for this? https://discourse.cmake.org/t/cmake-target-include-directories-doesnt-export-to-compile-commands-json-when-using-cuda/10072/2 I am using clangd language server for neovim, but it seems that it still can't expand rsp files

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/75753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. LGTM, thanks for the fix and test! https://github.com/llvm/llvm-project/pull/75753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-18 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/75753 >From 957951483dab19b0982a5dbe7d5370bd9061d931 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Sun, 17 Dec 2023 14:11:11 -0800 Subject: [PATCH 1/3] [clangd] Expand response files before CDB interpolation

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-18 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin edited https://github.com/llvm/llvm-project/pull/75753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-18 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: @HighCommander4 PTAL https://github.com/llvm/llvm-project/pull/75753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-18 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/75753 >From 957951483dab19b0982a5dbe7d5370bd9061d931 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Sun, 17 Dec 2023 14:11:11 -0800 Subject: [PATCH 1/2] [clangd] Expand response files before CDB interpolation

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-18 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. Thanks for having a look at this! Instead of performing the "expand response files" operation twice for commands coming from a `compile_commands.json` source, what do you think about the following: * Restore the call

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a418be96de7872f6058207c695ef4698cb1dbb93 957951483dab19b0982a5dbe7d5370bd9061d931 --

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Dmitry Polukhin (dmpolukhin) Changes Summary: After https://reviews.llvm.org/D143436 response files stopped working with CDB interpolation. It has happened because interpolation removes all unknwn flags and extra input files. Response

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

2023-12-17 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin created https://github.com/llvm/llvm-project/pull/75753 Summary: After https://reviews.llvm.org/D143436 response files stopped working with CDB interpolation. It has happened because interpolation removes all unknwn flags and extra input files. Response file is