Author: Jan Korous Date: 2020-01-16T15:07:08-08:00 New Revision: 42b3c38903c9c80e129ce678db7f522967e91eeb
URL: https://github.com/llvm/llvm-project/commit/42b3c38903c9c80e129ce678db7f522967e91eeb DIFF: https://github.com/llvm/llvm-project/commit/42b3c38903c9c80e129ce678db7f522967e91eeb.diff LOG: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS The test is failing on our CI bots. Seems like the order of results for one target is undefined. (post-commit review) Differential Revision: https://reviews.llvm.org/D72883 Added: Modified: clang-tools-extra/clangd/unittests/FindTargetTests.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/unittests/FindTargetTests.cpp b/clang-tools-extra/clangd/unittests/FindTargetTests.cpp index 408ebe24e773..c96b3a572322 100644 --- a/clang-tools-extra/clangd/unittests/FindTargetTests.cpp +++ b/clang-tools-extra/clangd/unittests/FindTargetTests.cpp @@ -770,6 +770,10 @@ TEST_F(FindExplicitReferencesTest, All) { "1: targets = {vector}\n" "2: targets = {x}\n"}, // Handle UnresolvedLookupExpr. + // FIXME + // This case fails when expensive checks are enabled. + // Seems like the order of ns1::func and ns2::func isn't defined. + #ifndef EXPENSIVE_CHECKS {R"cpp( namespace ns1 { void func(char*); } namespace ns2 { void func(int*); } @@ -783,6 +787,7 @@ TEST_F(FindExplicitReferencesTest, All) { )cpp", "0: targets = {ns1::func, ns2::func}\n" "1: targets = {t}\n"}, + #endif // Handle UnresolvedMemberExpr. {R"cpp( struct X { _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
