Author: Alexis Murzeau Date: 2023-02-24T07:15:19Z New Revision: 87447bedac341f023569f1b444f9b3b62bba5aa6
URL: https://github.com/llvm/llvm-project/commit/87447bedac341f023569f1b444f9b3b62bba5aa6 DIFF: https://github.com/llvm/llvm-project/commit/87447bedac341f023569f1b444f9b3b62bba5aa6.diff LOG: [clang-tidy] Fix readability-identifer-naming Hungarian CString options When reading readability-identifier-naming.HungarianNotation.CString options, correctly use the type string stored in CStr.second instead of the option name (CStr.first) as the HNOption.CString map key. This will make CString options really working and properly parsed by the checker. Reviewed By: carlosgalvezp Differential Revision: https://reviews.llvm.org/D144431 Added: Modified: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst Removed: ################################################################################ diff --git a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp index 96bf035843577..dd9a4fa9b8e30 100644 --- a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp @@ -472,7 +472,7 @@ void IdentifierNamingCheck::HungarianNotation::loadFileConfig( Buffer.append(CStr.first); StringRef Val = Options.get(Buffer, ""); if (!Val.empty()) - HNOption.CString[CStr.first] = Val.str(); + HNOption.CString[CStr.second] = Val.str(); } Buffer = {Section, "PrimitiveType."}; diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index 6b757656377d3..10f8e4c179777 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -169,6 +169,10 @@ Changes in existing checks <clang-tidy/checks/misc/unused-using-decls>` check. Global options of the same name should be used instead. +- Fixed reading `HungarianNotation.CString.*` options in + :doc:`readability-identifier-naming + <clang-tidy/checks/readability/identifier-naming>` check. + Removed checks ^^^^^^^^^^^^^^ _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
