Re: [clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

2020-01-13 Thread Nico Weber via cfe-commits
Great, thanks! On Mon, Jan 13, 2020 at 4:04 PM Aaron Ballman wrote: > On Mon, Jan 13, 2020 at 2:25 PM Nico Weber wrote: > > > > This breaks tests on Windows: http://45.33.8.238/win/5636/step_8.txt > > > > Likely the usual "doesn't work with delayed template parsing" thing. > > > > Can you take

Re: [clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

2020-01-13 Thread Aaron Ballman via cfe-commits
On Mon, Jan 13, 2020 at 2:25 PM Nico Weber wrote: > > This breaks tests on Windows: http://45.33.8.238/win/5636/step_8.txt > > Likely the usual "doesn't work with delayed template parsing" thing. > > Can you take a look, and if it takes a while to fix, revert while you > investigate? > > (I

Re: [clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

2020-01-13 Thread Nico Weber via cfe-commits
This breaks tests on Windows: http://45.33.8.238/win/5636/step_8.txt Likely the usual "doesn't work with delayed template parsing" thing. Can you take a look, and if it takes a while to fix, revert while you investigate? (I wouldn't said this on the phab issue, but couldn't find one.) On Mon,

[clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

2020-01-13 Thread Aaron Ballman via cfe-commits
Author: Nathan James Date: 2020-01-13T13:28:55-05:00 New Revision: fb79ef524171c96a9f3df025ac7a8a3e00fdc0b4 URL: https://github.com/llvm/llvm-project/commit/fb79ef524171c96a9f3df025ac7a8a3e00fdc0b4 DIFF: https://github.com/llvm/llvm-project/commit/fb79ef524171c96a9f3df025ac7a8a3e00fdc0b4.diff