Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-07-12 Thread David Blaikie via cfe-commits
Thanks all! On Wed, Jul 12, 2017 at 7:46 AM Alexander Kornienko wrote: > Done in r307661. > > On Mon, Jul 10, 2017 at 2:08 PM, Alexander Kornienko > wrote: > >> Benjamin has actually fixed the issue by reverting to the old behavior in >> r306822. >> I'll

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-07-12 Thread Alexander Kornienko via cfe-commits
Done in r307661. On Mon, Jul 10, 2017 at 2:08 PM, Alexander Kornienko wrote: > Benjamin has actually fixed the issue by reverting to the old behavior in > r306822. > I'll add a test for this behavior anyway. > > On Mon, Jul 10, 2017 at 11:47 AM, Alexander Kornienko

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-07-10 Thread Alexander Kornienko via cfe-commits
Benjamin has actually fixed the issue by reverting to the old behavior in r306822. I'll add a test for this behavior anyway. On Mon, Jul 10, 2017 at 11:47 AM, Alexander Kornienko wrote: > Sorry, missed this thread somehow. So, the behavior itself seems > incorrect. Clang

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-07-10 Thread Alexander Kornienko via cfe-commits
Sorry, missed this thread somehow. So, the behavior itself seems incorrect. Clang tools should not be trying to find a compilation database in case the command line has a `--`, but the driver fails to parse it. It should be a hard failure. We also need a reliable test for this behavior (with a

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-26 Thread David Blaikie via cfe-commits
On Mon, Jun 26, 2017 at 5:31 AM Serge Pavlov wrote: > 2017-06-26 4:05 GMT+07:00 David Blaikie : > >> Ah, I see now then. >> >> I have a symlink from the root of my source directory pointing to the >> compile_commands.json in my build directory. >> >> I

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-26 Thread Serge Pavlov via cfe-commits
2017-06-26 4:05 GMT+07:00 David Blaikie : > Ah, I see now then. > > I have a symlink from the root of my source directory pointing to the > compile_commands.json in my build directory. > > I have this so that the vim YouCompleteMe plugin (& any other clang tools) > can find

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-25 Thread David Blaikie via cfe-commits
Ah, I see now then. I have a symlink from the root of my source directory pointing to the compile_commands.json in my build directory. I have this so that the vim YouCompleteMe plugin (& any other clang tools) can find it, as they usually should, for using tools with the llvm/clang project...

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-25 Thread Serge Pavlov via cfe-commits
2017-06-25 0:52 GMT+07:00 David Blaikie : > > > On Sat, Jun 24, 2017 at 10:08 AM Serge Pavlov wrote: > >> With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is >> created in the directory >> /tools/clang/tools/extra/test/clang-tidy/Output,

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-24 Thread David Blaikie via cfe-commits
On Sat, Jun 24, 2017 at 10:08 AM Serge Pavlov wrote: > With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is > created in the directory > /tools/clang/tools/extra/test/clang-tidy/Output, > I'd be really surprised if this is the case - why would

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-24 Thread Serge Pavlov via cfe-commits
With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is created in the directory /tools/clang/tools/extra/test/clang-tidy/Output, but the tests from /llvm/tools/clang/tools/extra/test/clang-tidy run in the directory /tools/clang/tools/extra/test/clang-tidy, which does not contain json

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-23 Thread David Blaikie via cfe-commits
Ping (+Manuel, perhaps he's got some ideas about this, given background in the tooling & compilation database work, or could point this to someone who does?) On Thu, Jun 15, 2017 at 10:40 AM David Blaikie wrote: >

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-15 Thread David Blaikie via cfe-commits
https://sarcasm.github.io/notes/dev/compilation-database.html#cmake If you enable the CMAKE_EXPORT_COMPILE_COMMANDS option in cmake (& have a sufficiently recent cmake), then CMake will generate a compile_commands.json in the root of the build tree. The test finds this & fails, instead of finding

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-15 Thread Serge Pavlov via cfe-commits
2017-06-15 2:43 GMT+07:00 David Blaikie : > > > On Wed, Jun 14, 2017, 8:17 AM Serge Pavlov wrote: > >> 2017-06-14 4:24 GMT+07:00 David Blaikie : >> >>> Ah, I find that the test passes if I remove the compile_commands.json >>> file from

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-14 Thread David Blaikie via cfe-commits
On Wed, Jun 14, 2017, 8:17 AM Serge Pavlov wrote: > 2017-06-14 4:24 GMT+07:00 David Blaikie : > >> Ah, I find that the test passes if I remove the compile_commands.json >> file from my build directory (I have Ninja configured to generate a >>

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-14 Thread Serge Pavlov via cfe-commits
2017-06-14 4:24 GMT+07:00 David Blaikie : > Ah, I find that the test passes if I remove the compile_commands.json file > from my build directory (I have Ninja configured to generate a > compile_commands.json file). > > Looks like what happens is it finds the compilation

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-13 Thread David Blaikie via cfe-commits
Ah, I find that the test passes if I remove the compile_commands.json file from my build directory (I have Ninja configured to generate a compile_commands.json file). Looks like what happens is it finds the compilation database and fails hard when the database doesn't contain a compile command

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-13 Thread Serge Pavlov via cfe-commits
I cannot reproduce such fail, so I can only guess how changes made in https://reviews.llvm.org/rL303756 and https://reviews.llvm.org/rL303741 could cause such problem. Behavior of `Driver::BuildCompilation` is changed so that it returns null pointer if errors occur during driver argument parse. It

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-12 Thread David Blaikie via cfe-commits
I've been seeing errors from this test recently: Command Output (stderr): -- 1 error generated. Error while processing /usr/local/google/home/blaikie/dev/llvm/src/tools/clang/tools/extra/test/clang-tidy/diagnostic.cpp.nonexistent.cpp.