Re: [clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

I think on Linux overload resolution was selecting 'DiagnosticBuilder<<(DiagnosticBuilder,int)' for you, which is probably not right anyway. I didn't find any tests for this diagnostic, so I couldn't fix it, and ended up reverting the change in r310661. On Thu, Aug 10, 2017 at 12:15 PM, Yan Wang

Re: [clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

Yes. Sorry for the broken. But it works well in my Linux machine. Maybe I should revert it first. Thanks, Yan Wang On Thu, Aug 10, 2017 at 12:07 PM, Nico Weber wrote: > Not sure if you've seen it, this broke the Windows build: >

Re: [clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

Not sure if you've seen it, this broke the Windows build: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/5880/steps/build%20stage%201/logs/stdio FAILED: C:\PROGRA~2\MICROS~3.0\VC\bin\amd64\cl.exe /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE

[clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

Author: yawanng Date: Thu Aug 10 10:18:10 2017 New Revision: 310630 URL: http://llvm.org/viewvc/llvm-project?rev=310630=rev Log: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module. Summary: 1. Refactor the structure of the code by adding a base