RE: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

2017-11-21 Thread Yung, Douglas via cfe-commits
fe-commits Subject: Re: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr. Hi Douglas, Sorry about that! It's an encoding problem, I forgot there were encodings other than UTF-8 :-) I'll fix it. Thanks for the heads up. On Tue, Nov 21, 2017 at 7:56 PM, Yung, D

Re: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

2017-11-21 Thread Sam McCall via cfe-commits
64-scei-ps4- > windows10pro-fast\llvm.src\tools\clang\tools\extra\unittests\clangd\JSONExprTests.cpp(134): > error C2124: divide or mod by zero > > Can you fix this so that we can get the bot green again? Thanks! > > Douglas Yung > > > -Original Message- > >

RE: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

2017-11-21 Thread Yung, Douglas via cfe-commits
21, 2017 11:07 To: Yung, Douglas Cc: cfe-commits Subject: Re: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr. Hi Douglas, Sorry about that! It's an encoding problem, I forgot there were encodings other than UTF-8 :-) I'll fix it. Thanks for the heads up

Re: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

2017-11-21 Thread Sam McCall via cfe-commits
ng > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Sam > > McCall via cfe-commits > > Sent: Tuesday, November 21, 2017 8:01 > > To: cfe-commits@lists.llvm.org > > Subject: [clang-tools-ex

RE: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

2017-11-21 Thread Yung, Douglas via cfe-commits
@lists.llvm.org > Subject: [clang-tools-extra] r318774 - [clangd] Add parsing and value > inspection to JSONExpr. > > Author: sammccall > Date: Tue Nov 21 08:00:53 2017 > New Revision: 318774 > > URL: http://llvm.org/viewvc/llvm-project?rev=318774=rev > Log: > [clangd]

[clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

2017-11-21 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 21 08:00:53 2017 New Revision: 318774 URL: http://llvm.org/viewvc/llvm-project?rev=318774=rev Log: [clangd] Add parsing and value inspection to JSONExpr. Summary: This will replace the places where we're using YAMLParser to parse JSON now: - the new marshalling