Author: chandlerc Date: Sat Apr 21 16:27:34 2018 New Revision: 330528 URL: http://llvm.org/viewvc/llvm-project?rev=330528&view=rev Log: Revert r330492: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'
This commit has been breaking most bots for a day now. There is a fix proposed in https://reviews.llvm.org/D45912 but when I applied that I just got different errors. Reverting to get our bots back to green. Removed: clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming-objc.m Modified: clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp?rev=330528&r1=330527&r2=330528&view=diff ============================================================================== --- clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp (original) +++ clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp Sat Apr 21 16:27:34 2018 @@ -109,7 +109,6 @@ namespace readability { m(TemplateParameter) \ m(TypeAlias) \ m(MacroDefinition) \ - m(ObjcIvar) \ enum StyleKind { #define ENUMERATE(v) SK_ ## v, @@ -385,9 +384,6 @@ static StyleKind findStyleKind( const NamedDecl *D, const std::vector<llvm::Optional<IdentifierNamingCheck::NamingStyle>> &NamingStyles) { - if (isa<ObjCIvarDecl>(D) && NamingStyles[SK_ObjcIvar]) - return SK_ObjcIvar; - if (isa<TypedefDecl>(D) && NamingStyles[SK_Typedef]) return SK_Typedef; Removed: clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming-objc.m URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming-objc.m?rev=330527&view=auto ============================================================================== --- clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming-objc.m (original) +++ clang-tools-extra/trunk/test/clang-tidy/readability-identifier-naming-objc.m (removed) @@ -1,15 +0,0 @@ -// RUN: %check_clang_tidy %s readability-identifier-naming %t \ -// RUN: -config='{CheckOptions: \ -// RUN: [{key: readability-identifier-naming.ObjcIvarPrefix, value: '_'}]}' \ -// RUN: -- - -@interface Foo -@end - -@interface Foo () { - int _bar; - int barWithoutPrefix; - // CHECK-MESSAGES: :[[@LINE-1]]:9: warning: invalid case style for objc ivar 'barWithoutPrefix' [readability-identifier-naming] - // CHECK-FIXES: int _barWithoutPrefix; -} -@end _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits