Re: [clang-tools-extra] r356849 - [pp-trace] Modernize the code

2019-03-25 Thread Fāng-ruì Sòng via cfe-commits
s Yung > > -Original Message- > From: Fāng-ruì Sòng > Sent: Monday, March 25, 2019 4:41 > To: Yung, Douglas > Cc: cfe-commits > Subject: Re: [clang-tools-extra] r356849 - [pp-trace] Modernize the code > > Is it fixed now? > > On Mon, Mar 25, 2019 at 7

RE: [clang-tools-extra] r356849 - [pp-trace] Modernize the code

2019-03-25 Thread via cfe-commits
: [clang-tools-extra] r356849 - [pp-trace] Modernize the code Is it fixed now? On Mon, Mar 25, 2019 at 7:25 AM wrote: > > Hi Fangrui, > > This change is causing the PS4 Windows bot to fail to build: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windo >

Re: [clang-tools-extra] r356849 - [pp-trace] Modernize the code

2019-03-25 Thread Fāng-ruì Sòng via cfe-commits
r' > C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\include\llvm/Support/Error.h(176): > note: see declaration of 'llvm::Error::Error' > C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\include\llvm/Support/E

RE: [clang-tools-extra] r356849 - [pp-trace] Modernize the code

2019-03-24 Thread via cfe-commits
nclude\llvm/Support/Error.h(157): note: see declaration of 'llvm::Error' Can you take a look? Douglas Yung -Original Message- From: cfe-commits On Behalf Of Fangrui Song via cfe-commits Sent: Saturday, March 23, 2019 23:55 To: cfe-commits@lists.llvm.org Subject: [clang-tools

[clang-tools-extra] r356849 - [pp-trace] Modernize the code

2019-03-23 Thread Fangrui Song via cfe-commits
Author: maskray Date: Sat Mar 23 23:55:08 2019 New Revision: 356849 URL: http://llvm.org/viewvc/llvm-project?rev=356849&view=rev Log: [pp-trace] Modernize the code Use InitLLVM and WithColor Delete PPTraceConsumer, add the callback in PPTraceAction Migrae to tooling::createExecutorFromCommandLine