Re: [libcxx] r249929 - Split out of .

Thanks, Richard! Just to confirm, the test is passing now. Michael > On Oct 29, 2015, at 5:22 PM, Richard Smith wrote: > > I reverted this change in r251665, and started a new thread for the patch to > reinstate this and fix the ambiguity issue. > > On Wed, Oct 28,

Re: [libcxx] r249929 - Split out of .

I reverted this change in r251665, and started a new thread for the patch to reinstate this and fix the ambiguity issue. On Wed, Oct 28, 2015 at 11:01 AM, Michael Zolotukhin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Eric, Richard, > > Any news on this? The test is still broken,

Re: [libcxx] r249929 - Split out of .

Hi Eric, Richard, Any news on this? The test is still broken, should we revert the commit for now? Thanks, Michael > On Oct 24, 2015, at 1:18 AM, Eric Fiselier wrote: > > Hi Michael, > > Sorry I'm holding this patch up in review. The fix is quite "novel" and I > want to make

Re: [libcxx] r249929 - Split out of .

Hi Eric, Understood, thanks! Michael > On Oct 24, 2015, at 1:18 AM, Eric Fiselier wrote: > > Hi Michael, > > Sorry I'm holding this patch up in review. The fix is quite "novel" and I > want to make sure we get it right. If we can't land it over the weekend I'll > ask Richard

Re: [libcxx] r249929 - Split out of .

Hi Michael, Sorry I'm holding this patch up in review. The fix is quite "novel" and I want to make sure we get it right. If we can't land it over the weekend I'll ask Richard to revert while we work on it. /Eric On Oct 23, 2015 10:13 PM, "Michael Zolotukhin via cfe-commits" <

Re: [libcxx] r249929 - Split out of .

Hi Richard, Is this patch ready for commit, or were you just checking an idea? Our bots are still failing to build povray, so we’re really looking forward for some fix:) Thanks, Michael > On Oct 15, 2015, at 6:21 PM, Manman Ren via cfe-commits > wrote: > >> >>

Re: [libcxx] r249929 - Split out of .

On Thu, Oct 15, 2015 at 12:03 PM, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Oct 15, 2015, at 11:25 AM, Richard Smith wrote: > > I assume the code in question has a "using namespace std;"? > > Yes > > I don't see any way around this other than

Re: [libcxx] r249929 - Split out of .

I assume the code in question has a "using namespace std;"? I don't see any way around this other than giving up on trying to fix the function signatures here (or maybe adding a Clang feature to let us fix the bad signature). On Oct 15, 2015 11:07 AM, "Manman Ren via cfe-commits" <

Re: [libcxx] r249929 - Split out of .

> On Oct 15, 2015, at 11:25 AM, Richard Smith wrote: > > I assume the code in question has a "using namespace std;"? > > Yes > I don't see any way around this other than giving up on trying to fix the > function signatures here (or maybe adding a Clang feature to let

Re: [libcxx] r249929 - Split out of .

Hi Richard, This is causing a failure when building povray on iOS. Compilation error: /Users/buildslave/tmp/test-suite-externals/speccpu2006/benchspec/CPU2006/453.povray/src/fileinputoutput.cpp:364:20: error: call to 'strrchr' is ambiguous const char *p=strrchr(name, '.’);

[libcxx] r249929 - Split out of .

Author: rsmith Date: Fri Oct 9 20:25:31 2015 New Revision: 249929 URL: http://llvm.org/viewvc/llvm-project?rev=249929=rev Log: Split out of . Also fix the overload set for the five functions whose signatures change in the case where we can fix it. This is already covered by existing tests for