Re: [libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

Thank you! On Wed, Feb 17, 2016 at 9:23 PM, Eric Fiselier wrote: > Hopefully fixed in r261180. > > On Sat, Feb 13, 2016 at 2:08 PM, Evgenii Stepanov > wrote: >> >> Hi, >> >> this is my error message: >> >> In file included from z.cc:1: >>

Re: [libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

Hopefully fixed in r261180. On Sat, Feb 13, 2016 at 2:08 PM, Evgenii Stepanov wrote: > Hi, > > this is my error message: > > In file included from z.cc:1: > /code/build-llvm/bin/../include/c++/v1/ext/hash_map:213:5: warning: > Use of the header is deprecated.

Re: [libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

> The "hash_map" part of the name means they belong to "", and the actual type is defined in that header. Woops, Sorry I guess the name is used in both "std::__1::" in unordered_map and "__gnu_cxx::" in . My intention in the changes was to forward declare "std::__1::__hash_map_iterator". On Sat,

Re: [libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

> hash_map still looks broken to me. Uh oh, Sorry :-S. The original breakage was caused by the removal of a typedef "hash_map" used, but I'm sure I fixed that. > should not they be prefixed with __gnu_cxx:: ? No, they are in the correct namespace. The "hash_map" part of the name means they

Re: [libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

Hi, this is my error message: In file included from z.cc:1: /code/build-llvm/bin/../include/c++/v1/ext/hash_map:213:5: warning: Use of the header is deprecated. Migrate to [-W#warnings] # warning Use of the header is deprecated. Migrate to ^

Re: [libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

Hi, hash_map still looks broken to me. I don't have a simple reproducer, but these declarations in __hash_table: template class _LIBCPP_TYPE_VIS_ONLY __hash_map_iterator; template class _LIBCPP_TYPE_VIS_ONLY __hash_map_const_iterator; should not they be prefixed with __gnu_cxx:: ? Clang

[libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

Author: ericwf Date: Wed Feb 10 14:46:23 2016 New Revision: 260431 URL: http://llvm.org/viewvc/llvm-project?rev=260431=rev Log: Recommit r260012 - Cleanup node-type handling in the unordered containers. This time I kept working! This patch is the first in a series of patches that's meant to