Re: [libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-05 Thread Eric Fiselier via cfe-commits
Sorry about that guys, I was AFK most of the day today. Thanks for cleaning up my mess. On Feb 5, 2018 7:08 PM, "Nirav Davé" wrote: > I reverted r324182, r324185, and r324192 in r324309. Things should be > unstuck now. > > -Nirav > > On Mon, Feb 5, 2018 at 9:06 PM, Nirav

Re: [libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-05 Thread Nirav Davé via cfe-commits
I reverted r324182, r324185, and r324192 in r324309. Things should be unstuck now. -Nirav On Mon, Feb 5, 2018 at 9:06 PM, Nirav Davé wrote: > It looks like we need to revert 324182 and 324194. I'll revert on I > reverify on trunk. > >

Re: [libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-05 Thread Nirav Davé via cfe-commits
It looks like we need to revert 324182 and 324194. I'll revert on I reverify on trunk. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-05 Thread Nirav Davé via cfe-commits
https://bugs.llvm.org/show_bug.cgi?id=36241 On Mon, Feb 5, 2018 at 10:20 AM Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This broke the Chromium build, see > https://bugs.chromium.org/p/chromium/issues/detail?id=809050#c2 > > I see there were a lot of changes landed

Re: [libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-05 Thread Hans Wennborg via cfe-commits
This broke the Chromium build, see https://bugs.chromium.org/p/chromium/issues/detail?id=809050#c2 I see there were a lot of changes landed around the same time, so I'm not sure what to revert here exactly. On Sun, Feb 4, 2018 at 2:03 AM, Eric Fiselier via cfe-commits

[libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 17:03:08 2018 New Revision: 324182 URL: http://llvm.org/viewvc/llvm-project?rev=324182=rev Log: [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types. Summary: This patch fixes llvm.org/PR35491 and LWG2157