Re: r294401 - Sema: add warning for c++ member variable shadowing

2017-02-07 Thread Sean Silva via cfe-commits
Nice! On Tue, Feb 7, 2017 at 7:30 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Tue Feb 7 21:30:13 2017 > New Revision: 294401 > > URL: http://llvm.org/viewvc/llvm-project?rev=294401=rev > Log: > Sema: add warn

r294401 - Sema: add warning for c++ member variable shadowing

2017-02-07 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Feb 7 21:30:13 2017 New Revision: 294401 URL: http://llvm.org/viewvc/llvm-project?rev=294401=rev Log: Sema: add warning for c++ member variable shadowing Add a warning for shadowed variables across records. Referencing a shadow'ed variable may not give the desired

Re: Add warning for c++ member variable shadowing

2017-02-07 Thread Jonathan Roelofs via cfe-commits
On 2/7/17 7:30 PM, Saleem Abdulrasool wrote: On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs > wrote: On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote: Don't use the cast for the check, use isa.

Re: Add warning for c++ member variable shadowing

2017-02-07 Thread Saleem Abdulrasool via cfe-commits
On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs wrote: > > > On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote: > >> Don't use the cast for the check, use isa. Although, since you use the >> value later, it is probably better to write this as: >> >> if

Re: Add warning for c++ member variable shadowing

2017-02-07 Thread Jonathan Roelofs via cfe-commits
On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote: Don't use the cast for the check, use isa. Although, since you use the value later, it is probably better to write this as: if (const auto *RD = cast(CurContext)) CheckShadowInheritedVariabless(Loc, Name.getAsString(),

Re: Add warning for c++ member variable shadowing

2017-02-07 Thread Richard Smith via cfe-commits
> James > > > > *From: *<meta...@gmail.com> on behalf of Richard Smith < > rich...@metafoo.co.uk> > *Date: *Saturday, February 4, 2017 at 10:43 PM > *To: *James Sun <james...@fb.com> > *Cc: *Saleem Abdulrasool <compn...@compnerd.org>, " &

Re: Add warning for c++ member variable shadowing

2017-02-07 Thread James Sun via cfe-commits
asool <compn...@compnerd.org>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman <aa...@aaronballman.com> Subject: Re: Add warning for c++ member variable shadowing Thanks Richard! Hopefully this is the last patch :D Could you please help me to comm

Re: Add warning for c++ member variable shadowing

2017-02-04 Thread James Sun via cfe-commits
Abdulrasool <compn...@compnerd.org>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman <aa...@aaronballman.com> Subject: Re: Add warning for c++ member variable shadowing Thanks, just one more thing I noticed (sorry!) and this looks good to go. +d

Re: Add warning for c++ member variable shadowing

2017-02-04 Thread Richard Smith via cfe-commits
gt; cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman < > aa...@aaronballman.com> > *Subject: *Re: Add warning for c++ member variable shadowing > > > > updated > > > > *From: *James Sun <james...@fb.com> > *Date: *Sa

Re: Add warning for c++ member variable shadowing

2017-02-04 Thread James Sun via cfe-commits
ists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman <aa...@aaronballman.com> Subject: Re: Add warning for c++ member variable shadowing Ok I get your point. Suppose there are two paths from class B to base class A. One is with access as_none; the other is as_public. Then there

Re: Add warning for c++ member variable shadowing

2017-02-04 Thread James Sun via cfe-commits
fe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman <aa...@aaronballman.com<mailto:aa...@aaronballman.com>> Subject: Re: Add warning for c++ member variable shadowing Thanks, James! I think I have only one more substantive comment: + (Field-&g

Re: Add warning for c++ member variable shadowing

2017-02-04 Thread James Sun via cfe-commits
com>> Cc: Saleem Abdulrasool <compn...@compnerd.org<mailto:compn...@compnerd.org>>, "cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>" <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman <aa...@aaronb

Re: Add warning for c++ member variable shadowing

2017-02-04 Thread James Sun via cfe-commits
vm.org>" <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman <aa...@aaronballman.com<mailto:aa...@aaronballman.com>> Subject: Re: Add warning for c++ member variable shadowing Thanks, James! I think I have only one more substantive comment:

Re: Add warning for c++ member variable shadowing

2017-02-04 Thread Richard Smith via cfe-commits
Date: *Thursday, February 2, 2017 at 11:59 AM > *To: *James Sun <james...@fb.com> > *Cc: *Saleem Abdulrasool <compn...@compnerd.org>, " > cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman < > aa...@aaronballman.com> > *Subject:

Re: Add warning for c++ member variable shadowing

2017-02-04 Thread James Sun via cfe-commits
rd.org>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman <aa...@aaronballman.com> Subject: Re: Add warning for c++ member variable shadowing Thanks, James! I think I have only one more substantive comment: + (Field->getAccess() == AS_public ||

Re: Add warning for c++ member variable shadowing

2017-02-02 Thread Richard Smith via cfe-commits
n behalf of Richard Smith < > rich...@metafoo.co.uk> > *Date: *Wednesday, February 1, 2017 at 3:50 PM > *To: *James Sun <james...@fb.com> > > *Cc: *Saleem Abdulrasool <compn...@compnerd.org>, " > cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org

Re: Add warning for c++ member variable shadowing

2017-02-02 Thread James Sun via cfe-commits
rd.org>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman <aa...@aaronballman.com> Subject: Re: Add warning for c++ member variable shadowing + std::set bases; +const auto baseName = Specifier->getType()->getAsCXXRecordDecl()->getName(); Ple

Re: Add warning for c++ member variable shadowing

2017-02-01 Thread Richard Smith via cfe-commits
> > *To: *James Sun <james...@fb.com> > *Cc: *Richard Smith <rich...@metafoo.co.uk>, "cfe-commits@lists.llvm.org" > <cfe-commits@lists.llvm.org>, Aaron Ballman <aa...@aaronballman.com> > *Subject: *Re: Add warning for c++ member variable shadowing &g

Re: Add warning for c++ member variable shadowing

2017-01-31 Thread James Sun via cfe-commits
gt;>, "cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>" <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman <aa...@aaronballman.com<mailto:aa...@aaronballman.com>> Subject: Re: Add warning for c++ member vari

Re: Add warning for c++ member variable shadowing

2017-01-31 Thread Saleem Abdulrasool via cfe-commits
ames...@fb.com> > *Cc: *Richard Smith <rich...@metafoo.co.uk>, "cfe-commits@lists.llvm.org" > <cfe-commits@lists.llvm.org>, Aaron Ballman <aa...@aaronballman.com> > > *Subject: *Re: Add warning for c++ member variable shadowing > > > > I think that the pa

Re: Add warning for c++ member variable shadowing

2017-01-31 Thread James Sun via cfe-commits
b.com> Cc: Richard Smith <rich...@metafoo.co.uk>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman <aa...@aaronballman.com> Subject: Re: Add warning for c++ member variable shadowing I think that the patch is starting to look p

Re: Add warning for c++ member variable shadowing

2017-01-30 Thread Saleem Abdulrasool via cfe-commits
o: *James Sun <james...@fb.com> > *Cc: *Saleem Abdulrasool <compn...@compnerd.org>, " > cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman < > aa...@aaronballman.com> > > *Subject: *Re: Add warning for c++ member variable

Re: Add warning for c++ member variable shadowing

2017-01-30 Thread James Sun via cfe-commits
7 at 3:03 PM To: James Sun <james...@fb.com> Cc: Saleem Abdulrasool <compn...@compnerd.org>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron Ballman <aa...@aaronballman.com> Subject: Re: Add warning for c++ member variable shadowing +def warn_shadow_me

Re: Add warning for c++ member variable shadowing

2017-01-27 Thread Richard Smith via cfe-commits
; > > > > *From: *Saleem Abdulrasool <compn...@compnerd.org> > *Date: *Tuesday, January 24, 2017 at 7:10 PM > *To: *James Sun <james...@fb.com> > *Cc: *"cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org>, Aaron > Ballman <aa...@aaronballman.co

Re: Add warning for c++ member variable shadowing

2017-01-24 Thread James Sun via cfe-commits
llman.com>, Richard Smith <rich...@metafoo.co.uk> Subject: Re: Add warning for c++ member variable shadowing Some more stylistic comments: The description that you have on CheckShadowInheritedVariables isn't really the type of comments that we have in doxygen form. Im not sure if its in line

Re: Add warning for c++ member variable shadowing

2017-01-24 Thread Saleem Abdulrasool via cfe-commits
s...@fb.com> > *Date: *Tuesday, January 24, 2017 at 2:36 PM > *To: *"cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> > *Subject: *Add warning for c++ member variable shadowing > > > > Dear members > > > > Here is a patch (attached) to

Re: Add warning for c++ member variable shadowing

2017-01-24 Thread James Sun via cfe-commits
Coding style change From: James Sun <james...@fb.com> Date: Tuesday, January 24, 2017 at 2:36 PM To: "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> Subject: Add warning for c++ member variable shadowing Dear members Here is a patch (attached) to create w

Add warning for c++ member variable shadowing

2017-01-24 Thread James Sun via cfe-commits
Dear members Here is a patch (attached) to create warnings where a member variable shadows the one in one of its inheriting classes. For cases where we really don't want to shadow member variables, e.g. class a { int foo; } class b : a { int foo; // Generate a warning } This patch (1)