This revision was automatically updated to reflect the committed changes.
Closed by commit rC330331: Fix __attribute__((force_align_arg_pointer))
misalignment bug (authored by erichkeane, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45812
Files:
lib/CodeGen/TargetInfo.cpp
Author: erichkeane
Date: Thu Apr 19 07:27:05 2018
New Revision: 330331
URL: http://llvm.org/viewvc/llvm-project?rev=330331=rev
Log:
Fix __attribute__((force_align_arg_pointer)) misalignment bug
The force_align_arg_pointer attribute was using a hardcoded 16-byte
alignment value which
Gramner added a comment.
In https://reviews.llvm.org/D45812#1072128, @erichkeane wrote:
> LGTM, Do you have commit access, or do you want me to commit it for you?
I do not have commit access, so please do. Thanks for the review.
https://reviews.llvm.org/D45812
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
LGTM, Do you have commit access, or do you want me to commit it for you?
https://reviews.llvm.org/D45812
___
cfe-commits mailing list
Gramner added a comment.
In https://reviews.llvm.org/D45812#1072066, @erichkeane wrote:
> Can you make sure that this doesn't cause stackrealign to happen 2x if using
> -mstackrealign? Additionally, please provide the diff with full-context (see
>
Gramner updated this revision to Diff 143083.
Gramner added a comment.
Full context.
https://reviews.llvm.org/D45812
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/function-attributes.c
Index: test/CodeGen/function-attributes.c
erichkeane added a comment.
Can you make sure that this doesn't cause stackrealign to happen 2x if using
-mstackrealign? Additionally, please provide the diff with full-context (see
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).
What is the commit before
Gramner created this revision.
Gramner added a reviewer: erichkeane.
Gramner added a project: clang.
Herald added a subscriber: javed.absar.
The force_align_arg_pointer attribute was using a hardcoded 16-byte
alignment value which in combination with -mstack-alignment=32 (or
larger) would produce
Hej Henrik,
On Thu, 19 Apr 2018, Henrik Gramner via cfe-commits wrote:
The force_align_arg_pointer attribute was using a hardcoded 16-byte
alignment value which in combination with -mstack-alignment=32 (or
larger) would produce a misaligned stack which could result in crashes
when accessing
The force_align_arg_pointer attribute was using a hardcoded 16-byte
alignment value which in combination with -mstack-alignment=32 (or
larger) would produce a misaligned stack which could result in crashes
when accessing stack buffers using aligned AVX load/store
instructions.
The attached patch
10 matches
Mail list logo
