Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

2019-05-23 Thread Ilya Biryukov via cfe-commits
t;>>>> >>>>> >>>>> >>>>> *From:* Yitzhak Mandelbaum [mailto:yitzh...@google.com] >>>>> *Sent:* Wednesday, May 22, 2019 1:37 PM >>>>> *To:* reviews+d61774+public+f458bb6144ae8...@reviews.llvm.org >>>>&

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

2019-05-23 Thread Yitzhak Mandelbaum via cfe-commits
gt;>> *Sent:* Wednesday, May 22, 2019 1:37 PM >>>> *To:* reviews+d61774+public+f458bb6144ae8...@reviews.llvm.org >>>> *Cc:* Ilya Biryukov ; Penzin, Petr < >>>> petr.pen...@intel.com>; llvm-comm...@lists.llvm.org; Michał Górny < >>>> mgo...

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

2019-05-23 Thread Yitzhak Mandelbaum via cfe-commits
o:* reviews+d61774+public+f458bb6144ae8...@reviews.llvm.org >>> *Cc:* Ilya Biryukov ; Penzin, Petr < >>> petr.pen...@intel.com>; llvm-comm...@lists.llvm.org; Michał Górny < >>> mgo...@gentoo.org>; cfe-commits ; Theko >>> Lekena ; Nicolas Lesser ; >>>

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

2019-05-23 Thread Yitzhak Mandelbaum via cfe-commits
e8...@reviews.llvm.org >> *Cc:* Ilya Biryukov ; Penzin, Petr < >> petr.pen...@intel.com>; llvm-comm...@lists.llvm.org; Michał Górny < >> mgo...@gentoo.org>; cfe-commits ; Theko >> Lekena ; Nicolas Lesser ; >> Han Shen >> *Subject:* Re: [PATCH]

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

2019-05-23 Thread Ilya Biryukov via cfe-commits
reviews+d61774+public+f458bb6144ae8...@reviews.llvm.org > *Cc:* Ilya Biryukov ; Penzin, Petr < > petr.pen...@intel.com>; llvm-comm...@lists.llvm.org; Michał Górny < > mgo...@gentoo.org>; cfe-commits ; Theko > Lekena ; Nicolas Lesser ; > Han Shen > *Subject:* Re: [PATCH] D6

RE: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

2019-05-22 Thread Penzin, Petr via cfe-commits
; Penzin, Petr ; llvm-comm...@lists.llvm.org; Michał Górny ; cfe-commits ; Theko Lekena ; Nicolas Lesser ; Han Shen Subject: Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes. I'm confused by the error given that getStatementsRange

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

2019-05-22 Thread Yitzhak Mandelbaum via cfe-commits
I'm confused by the error given that getStatementsRange is a function name. I don't have Visual Studio -- can you find a fix and send a patch? I wonder if taking the address explicitly is enough? Or, if you know how to trigger this error in clang or gcc, I can fix it myself. On Wed, May 22,