; Erik Schwiebert <eri...@microsoft.com>;
Brian Kelley <bkel...@microsoft.com>; Tomasz Kukielka <tkuki...@microsoft.com>;
cfe-commits <cfe-commits@lists.llvm.org>
Subject: Re: r284060 - Implement MS _BitScan intrinsics
On Fri, Jun 16, 2017 at 5:08 PM, Duncan P. N. Exon Smith
<dexonsm..
ould live with that.
>>
>> Thanks,
>> Schwieb
>>
>> -Original Message-
>> From: Erik Schwiebert
>> Sent: Friday, June 16, 2017 8:49 AM
>> To: 'Bruno Cardoso Lopes' <bruno.card...@gmail.com>; Brian Kelley
>> <bkel...@microsoft
uno.card...@gmail.com>>; Brian Kelley <bkel...@microsoft.com
> <mailto:bkel...@microsoft.com>>; Tomasz Kukielka <tkuki...@microsoft.com
> <mailto:tkuki...@microsoft.com>>
> Cc: dexonsm...@apple.com <mailto:dexonsm...@apple.com>; Reid Kleckner
> <r...@googl
m: Erik Schwiebert
> Sent: Friday, June 16, 2017 8:49 AM
> To: 'Bruno Cardoso Lopes' <bruno.card...@gmail.com>; Brian Kelley <
> bkel...@microsoft.com>; Tomasz Kukielka <tkuki...@microsoft.com>
> Cc: dexonsm...@apple.com; Reid Kleckner <r...@google.com>; cfe-commits <
r <r...@google.com>; cfe-commits
<cfe-commits@lists.llvm.org>
Subject: RE: r284060 - Implement MS _BitScan intrinsics
Adding Brian and Tomasz. I'm pretty sure we have the Windows SDK intrinsics
headers. I'm not sure which method we'd prefer, so I'll walk down the hall and
ask them
@lists.llvm.org>
Subject: Re: r284060 - Implement MS _BitScan intrinsics
On Tue, Jun 13, 2017 at 8:13 PM, Bruno Cardoso Lopes
<bruno.card...@gmail.com> wrote:
> On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits
> <cfe-commits@lists.llvm.org> wrote:
>> SGTM too. R
ski
>> <agutow...@google.com>; David Majnemer <david.majne...@gmail.com>;
>> cfe-commits <cfe-commits@lists.llvm.org>; Erik Schwiebert
>> <eri...@microsoft.com>
>> Subject: Re: r284060 - Implement MS _BitScan intrinsics
>>
>>
>>>
leem Abdulrasool <compn...@compnerd.org>; Albert Gutowski
> <agutow...@google.com>; David Majnemer <david.majne...@gmail.com>;
> cfe-commits <cfe-commits@lists.llvm.org>; Erik Schwiebert
> <eri...@microsoft.com>
> Subject: Re: r284060 - Implement MS _
.org>; Erik Schwiebert <eri...@microsoft.com>
Subject: Re: r284060 - Implement MS _BitScan intrinsics
> On Jun 12, 2017, at 12:44, Reid Kleckner <r...@google.com> wrote:
>
>> On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool <compn...@compnerd.org>
>> wr
> On Jun 12, 2017, at 12:44, Reid Kleckner wrote:
>
>> On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool
>> wrote:
>> I'm worried about changing this signature all the time. I suspect that it
>> will cause the following to be emitted for valid code:
On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool
wrote:
> I'm worried about changing this signature all the time. I suspect that it
> will cause the following to be emitted for valid code:
>
> warning: incompatible pointer types passing 'unsigned long *' to parameter
>
Reid Kleckner'
<r...@google.com>; 'David Majnemer' <david.majne...@gmail.com>; 'cfe-commits'
<cfe-commits@lists.llvm.org>
Subject: RE: r284060 - Implement MS _BitScan intrinsics
It’s probably also better to not try to infer our weird desired behavior. It
should probably be contr
r <r...@google.com>;
David Majnemer <david.majne...@gmail.com>; cfe-commits
<cfe-commits@lists.llvm.org>
Subject: RE: r284060 - Implement MS _BitScan intrinsics
Yes, we definitely do not want to introduce pointer-type incompatibility
warnings. Predicating the behavior change on
.org>; Erik Schwiebert <eri...@microsoft.com>
Subject: Re: r284060 - Implement MS _BitScan intrinsics
I'm worried about changing this signature all the time. I suspect that it will
cause the following to be emitted for valid code:
warning: incompatible pointer types passing 'unsigned long *'
I'm worried about changing this signature all the time. I suspect that it
will cause the following to be emitted for valid code:
warning: incompatible pointer types passing 'unsigned long *' to parameter
of type 'unsigned int *' [-Wincompatible-pointer-types]
Switching the signature on LP64
[... excuse the necromancy...]
Hi Albert (and Reid and David),
This commit is breaking some uses of -fms-extensions on Apple platforms. In
particular, Brian and Erik (CC'ed) build against a version of the Windows SDK
on Apple platforms. _BitScanReverse is expected to be 32-bit, matching
16 matches
Mail list logo