RE: r284060 - Implement MS _BitScan intrinsics

2017-06-20 Thread Erik Schwiebert via cfe-commits
; Erik Schwiebert <eri...@microsoft.com>; Brian Kelley <bkel...@microsoft.com>; Tomasz Kukielka <tkuki...@microsoft.com>; cfe-commits <cfe-commits@lists.llvm.org> Subject: Re: r284060 - Implement MS _BitScan intrinsics On Fri, Jun 16, 2017 at 5:08 PM, Duncan P. N. Exon Smith <dexonsm..

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-19 Thread Bruno Cardoso Lopes via cfe-commits
ould live with that. >> >> Thanks, >> Schwieb >> >> -Original Message- >> From: Erik Schwiebert >> Sent: Friday, June 16, 2017 8:49 AM >> To: 'Bruno Cardoso Lopes' <bruno.card...@gmail.com>; Brian Kelley >> <bkel...@microsoft

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Duncan P. N. Exon Smith via cfe-commits
uno.card...@gmail.com>>; Brian Kelley <bkel...@microsoft.com > <mailto:bkel...@microsoft.com>>; Tomasz Kukielka <tkuki...@microsoft.com > <mailto:tkuki...@microsoft.com>> > Cc: dexonsm...@apple.com <mailto:dexonsm...@apple.com>; Reid Kleckner > <r...@googl

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Reid Kleckner via cfe-commits
m: Erik Schwiebert > Sent: Friday, June 16, 2017 8:49 AM > To: 'Bruno Cardoso Lopes' <bruno.card...@gmail.com>; Brian Kelley < > bkel...@microsoft.com>; Tomasz Kukielka <tkuki...@microsoft.com> > Cc: dexonsm...@apple.com; Reid Kleckner <r...@google.com>; cfe-commits <

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Erik Schwiebert via cfe-commits
r <r...@google.com>; cfe-commits <cfe-commits@lists.llvm.org> Subject: RE: r284060 - Implement MS _BitScan intrinsics Adding Brian and Tomasz. I'm pretty sure we have the Windows SDK intrinsics headers. I'm not sure which method we'd prefer, so I'll walk down the hall and ask them

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Erik Schwiebert via cfe-commits
@lists.llvm.org> Subject: Re: r284060 - Implement MS _BitScan intrinsics On Tue, Jun 13, 2017 at 8:13 PM, Bruno Cardoso Lopes <bruno.card...@gmail.com> wrote: > On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> SGTM too. R

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-15 Thread Bruno Cardoso Lopes via cfe-commits
ski >> <agutow...@google.com>; David Majnemer <david.majne...@gmail.com>; >> cfe-commits <cfe-commits@lists.llvm.org>; Erik Schwiebert >> <eri...@microsoft.com> >> Subject: Re: r284060 - Implement MS _BitScan intrinsics >> >> >>>

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-13 Thread Bruno Cardoso Lopes via cfe-commits
leem Abdulrasool <compn...@compnerd.org>; Albert Gutowski > <agutow...@google.com>; David Majnemer <david.majne...@gmail.com>; > cfe-commits <cfe-commits@lists.llvm.org>; Erik Schwiebert > <eri...@microsoft.com> > Subject: Re: r284060 - Implement MS _

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Erik Schwiebert via cfe-commits
.org>; Erik Schwiebert <eri...@microsoft.com> Subject: Re: r284060 - Implement MS _BitScan intrinsics > On Jun 12, 2017, at 12:44, Reid Kleckner <r...@google.com> wrote: > >> On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool <compn...@compnerd.org> >> wr

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Duncan P. N. Exon Smith via cfe-commits
> On Jun 12, 2017, at 12:44, Reid Kleckner wrote: > >> On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool >> wrote: >> I'm worried about changing this signature all the time. I suspect that it >> will cause the following to be emitted for valid code:

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Reid Kleckner via cfe-commits
On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool wrote: > I'm worried about changing this signature all the time. I suspect that it > will cause the following to be emitted for valid code: > > warning: incompatible pointer types passing 'unsigned long *' to parameter >

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Erik Schwiebert via cfe-commits
Reid Kleckner' <r...@google.com>; 'David Majnemer' <david.majne...@gmail.com>; 'cfe-commits' <cfe-commits@lists.llvm.org> Subject: RE: r284060 - Implement MS _BitScan intrinsics It’s probably also better to not try to infer our weird desired behavior. It should probably be contr

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-08 Thread Erik Schwiebert via cfe-commits
r <r...@google.com>; David Majnemer <david.majne...@gmail.com>; cfe-commits <cfe-commits@lists.llvm.org> Subject: RE: r284060 - Implement MS _BitScan intrinsics Yes, we definitely do not want to introduce pointer-type incompatibility warnings. Predicating the behavior change on

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-08 Thread Erik Schwiebert via cfe-commits
.org>; Erik Schwiebert <eri...@microsoft.com> Subject: Re: r284060 - Implement MS _BitScan intrinsics I'm worried about changing this signature all the time. I suspect that it will cause the following to be emitted for valid code: warning: incompatible pointer types passing 'unsigned long *'

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-07 Thread Saleem Abdulrasool via cfe-commits
I'm worried about changing this signature all the time. I suspect that it will cause the following to be emitted for valid code: warning: incompatible pointer types passing 'unsigned long *' to parameter of type 'unsigned int *' [-Wincompatible-pointer-types] Switching the signature on LP64

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-07 Thread Duncan P. N. Exon Smith via cfe-commits
[... excuse the necromancy...] Hi Albert (and Reid and David), This commit is breaking some uses of -fms-extensions on Apple platforms. In particular, Brian and Erik (CC'ed) build against a version of the Windows SDK on Apple platforms. _BitScanReverse is expected to be 32-bit, matching