RE: r296171 - Try to unbreak tests after r296166

2017-02-27 Thread Yung, Douglas via cfe-commits
...@google.com] Sent: Monday, February 27, 2017 15:13 To: Yung, Douglas Cc: cfe-commits; nicolaswe...@gmx.de Subject: Re: r296171 - Try to unbreak tests after r296166 I relanded the test in r296408. Since this deletes temp files created by the OS following an unpredictable pattern, exactly specifying

Re: r296171 - Try to unbreak tests after r296166

2017-02-27 Thread Nico Weber via cfe-commits
I relanded the test in r296408. Since this deletes temp files created by the OS following an unpredictable pattern, exactly specifying the filename to delete isn't possible. Let me know if putting a functional rm on your bots is a problem and then we can see if we can think of something else, but

RE: r296171 - Try to unbreak tests after r296166

2017-02-25 Thread Nico Weber via cfe-commits
Can't you just put gnuwin rm on your bot? Our Windows bots are happy with the test, and having to support an rm without wildcard support seems pretty strange. (Https://is.gd/chromeclang -> tools -> gnuwin-6.zip are the executables our bot uses to run llvm tests) On Feb 24, 2017 8:13 PM, "Yung,

RE: r296171 - Try to unbreak tests after r296166

2017-02-24 Thread Yung, Douglas via cfe-commits
Hi Nico, The test you added is causing a failure on the PS4 Windows bot. The root of the cause is that the Windows version of rm does not accept wildcards unfortunately. To fix make it work on Windows, you likely need to specify exactly what files/directories you want to delete without using a