Re: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-25 Thread Reid Kleckner via cfe-commits
essary. >> >> >> >> Thoughts? >> >> >> >> >> >> *From:* Nico Weber [mailto:tha...@google.com] >> *Sent:* Thursday, May 25, 2017 9:56 AM >> *To:* Keane, Erich <erich.ke...@intel.com> >> *Cc:* Blower, Melanie &l

Re: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-25 Thread Nico Weber via cfe-commits
:* Thursday, May 25, 2017 9:56 AM > *To:* Keane, Erich <erich.ke...@intel.com> > *Cc:* Blower, Melanie <melanie.blo...@intel.com>; rnk <r...@chromium.org>; > cfe-commits <cfe-commits@lists.llvm.org>; Hans Wennborg <h...@chromium.org > > > > *Subject:*

RE: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-25 Thread Keane, Erich via cfe-commits
e...@intel.com>>; cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>>; Hans Wennborg <h...@chromium.org<mailto:h...@chromium.org>> Subject: RE: r303798 - For Microsoft compatibility, set fno_operator_names In addition to this making clang-cl

RE: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-25 Thread Blower, Melanie via cfe-commits
: Thursday, May 25, 2017 12:56 PM To: Keane, Erich <erich.ke...@intel.com> Cc: Blower, Melanie <melanie.blo...@intel.com>; rnk <r...@chromium.org>; cfe-commits <cfe-commits@lists.llvm.org>; Hans Wennborg <h...@chromium.org> Subject: Re: r303798 - For Microsoft compati

Re: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-25 Thread Nico Weber via cfe-commits
..@intel.com> > *Cc:* rnk <r...@chromium.org>; Keane, Erich <erich.ke...@intel.com>; > cfe-commits <cfe-commits@lists.llvm.org>; Hans Wennborg <h...@chromium.org > > > > *Subject:* RE: r303798 - For Microsoft compatibility, set > fno_operator_names > >

RE: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-25 Thread Keane, Erich via cfe-commits
ch <erich.ke...@intel.com>; cfe-commits <cfe-commits@lists.llvm.org>; Hans Wennborg <h...@chromium.org> Subject: RE: r303798 - For Microsoft compatibility, set fno_operator_names In addition to this making clang-cl silently accept invalid code, it also breaks existing valid code, buil

RE: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-25 Thread Keane, Erich via cfe-commits
Keane, Erich <erich.ke...@intel.com>; cfe-commits <cfe-commits@lists.llvm.org>; Hans Wennborg <h...@chromium.org> Subject: RE: r303798 - For Microsoft compatibility, set fno_operator_names In addition to this making clang-cl silently accept invalid code, it also breaks existing valid cod

RE: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-25 Thread Nico Weber via cfe-commits
commits@lists.llvm.org>; rnk <r...@chromium.org> *Subject:* RE: r303798 - For Microsoft compatibility, set fno_operator_names Adding Melanie, the author of the patch. *From:* tha...@google.com [mailto:tha...@google.com <tha...@google.com>] *On Behalf Of *Nico Weber *Sent:* Wednesday, M

RE: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-24 Thread Blower, Melanie via cfe-commits
ch.ke...@intel.com>> Cc: cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>>; rnk <r...@chromium.org<mailto:r...@chromium.org>> Subject: Re: r303798 - For Microsoft compatibility, set fno_operator_names Reviewed here: https://reviews.llvm.org/D335

Re: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-24 Thread Nico Weber via cfe-commits
Reviewed here: https://reviews.llvm.org/D33505 Still, please make this warn. On Wed, May 24, 2017 at 3:42 PM, Nico Weber wrote: > Was this reviewed somewhere? > > Please make it so that this emits a warning. We want clang-cl to warn on > invalid code (and in system headers

Re: r303798 - For Microsoft compatibility, set fno_operator_names

2017-05-24 Thread Nico Weber via cfe-commits
Was this reviewed somewhere? Please make it so that this emits a warning. We want clang-cl to warn on invalid code (and in system headers warnings are suppressed). On Wed, May 24, 2017 at 3:31 PM, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Wed