RE: r349201 - Add extension to always default-initialize nullptr_t.

2019-01-17 Thread Keane, Erich via cfe-commits
and commit this. Thanks! -Erich From: Keane, Erich Sent: Friday, December 14, 2018 2:57 PM To: Richard Smith Cc: cfe-commits Subject: RE: r349201 - Add extension to always default-initialize nullptr_t. Thanks! I’ll take a look in a bit! -Erich From: Richard Smith [mailto:rich...@metafoo.co.uk

RE: r349201 - Add extension to always default-initialize nullptr_t.

2018-12-14 Thread Keane, Erich via cfe-commits
Thanks! I’ll take a look in a bit! -Erich From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Friday, December 14, 2018 2:55 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r349201 - Add extension to always default-initialize nullptr_t. Attached. With the functional part of your change

Re: r349201 - Add extension to always default-initialize nullptr_t.

2018-12-14 Thread Richard Smith via cfe-commits
’s a read from nullptr_t >> >> >> >> >> >> *From:* Richard Smith [mailto:rich...@metafoo.co.uk] >> *Sent:* Friday, December 14, 2018 2:41 PM >> *To:* Keane, Erich >> *Cc:* cfe-commits >> *Subject:* Re: r349201 - Add extension to always default-

Re: r349201 - Add extension to always default-initialize nullptr_t.

2018-12-14 Thread Richard Smith via cfe-commits
From:* Richard Smith [mailto:rich...@metafoo.co.uk] > *Sent:* Friday, December 14, 2018 2:41 PM > *To:* Keane, Erich > *Cc:* cfe-commits > *Subject:* Re: r349201 - Add extension to always default-initialize > nullptr_t. > > > > Sorry, I was late with my review comment. I think

RE: r349201 - Add extension to always default-initialize nullptr_t.

2018-12-14 Thread Keane, Erich via cfe-commits
Reverted in r349206. From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Friday, December 14, 2018 2:41 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r349201 - Add extension to always default-initialize nullptr_t. Sorry, I was late with my review comment. I think this is the wrong way

RE: r349201 - Add extension to always default-initialize nullptr_t.

2018-12-14 Thread Keane, Erich via cfe-commits
, Erich Cc: cfe-commits Subject: Re: r349201 - Add extension to always default-initialize nullptr_t. Sorry, I was late with my review comment. I think this is the wrong way to approach this problem. This does not "fix all situations where nullptr_t would seem uninitialized", and it mak

Re: r349201 - Add extension to always default-initialize nullptr_t.

2018-12-14 Thread Richard Smith via cfe-commits
Sorry, I was late with my review comment. I think this is the wrong way to approach this problem. This does not "fix all situations where nullptr_t would seem uninitialized", and it makes our AST representation lose source fidelity. On Fri, 14 Dec 2018 at 14:25, Erich Keane via cfe-commits <