Re: r358104 - Don't emit an unreachable return block.

2019-04-11 Thread Marco Castelluccio via cfe-commits
Thanks, your fix looks good to me. - Marco. Il 11/04/19 05:05, John McCall ha scritto: > > > On 10 Apr 2019, at 21:50, wolfgang.p...@sony.com wrote: > >> Hi, >> This commit seems to be causing a test failure on several buildbots >> (e.g. >>

Re: r358104 - Don't emit an unreachable return block.

2019-04-10 Thread John McCall via cfe-commits
On 10 Apr 2019, at 21:50, wolfgang.p...@sony.com wrote: Hi, This commit seems to be causing a test failure on several buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/26305). instrprof-shared-gcov-flush.test is failing because of differences in profile

RE: r358104 - Don't emit an unreachable return block.

2019-04-10 Thread via cfe-commits
Hi, This commit seems to be causing a test failure on several buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/26305). instrprof-shared-gcov-flush.test is failing because of differences in profile info. The test passes when I revert your change, so perhaps it's