Re: r269765 - Revert "[X86] Add immediate range checks for many of the builtins."

2016-05-18 Thread Filipe Cabecinhas via cfe-commits
Indeed, my bad on two counts (I'm usually one of the people complaining about commits like this, *and* I didn't notice the other email was not sent to the list, so there was no record here). Thanks Craig, for replying. Filipe On Tue, May 17, 2016 at 11:09 PM, Sean Silva via cfe-commits

Re: r269765 - Revert "[X86] Add immediate range checks for many of the builtins."

2016-05-17 Thread Craig Topper via cfe-commits
There was an off list mail to me on this. The 0-255 checks don't work for the builtins that take a char immediate and char is signed. In that case the range change needs to be -128 to 127 instead of 0 to 255. On Tue, May 17, 2016 at 3:09 PM, Sean Silva via cfe-commits <

Re: r269765 - Revert "[X86] Add immediate range checks for many of the builtins."

2016-05-17 Thread Sean Silva via cfe-commits
On Tue, May 17, 2016 at 7:07 AM, Filipe Cabecinhas via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: filcab > Date: Tue May 17 09:07:43 2016 > New Revision: 269765 > > URL: http://llvm.org/viewvc/llvm-project?rev=269765=rev > Log: > Revert "[X86] Add immediate range checks for many

r269765 - Revert "[X86] Add immediate range checks for many of the builtins."

2016-05-17 Thread Filipe Cabecinhas via cfe-commits
Author: filcab Date: Tue May 17 09:07:43 2016 New Revision: 269765 URL: http://llvm.org/viewvc/llvm-project?rev=269765=rev Log: Revert "[X86] Add immediate range checks for many of the builtins." This reverts commit r269619. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp