Re: r281395 - Try harder to not inline dllimport functions referencing non-dllimport functions

r281413 for the constructors. On Tue, Sep 13, 2016 at 2:58 PM, Hans Wennborg wrote: > Good point. Constructors are also a problem, I'll try to fix. > > It's not exactly the same issue, because they do show up in the AST, > but they're referenced with a CXXConstructExpr, and

Re: r281395 - Try harder to not inline dllimport functions referencing non-dllimport functions

Good point. Constructors are also a problem, I'll try to fix. It's not exactly the same issue, because they do show up in the AST, but they're referenced with a CXXConstructExpr, and not the DeclRefExpr which DLLImportFunctionVisitor is looking for. There doesn't seem to be any problem with

Re: r281395 - Try harder to not inline dllimport functions referencing non-dllimport functions

Could other implicit functions (operator=, ctors) have similar issues? On Tue, Sep 13, 2016 at 5:08 PM, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Tue Sep 13 16:08:20 2016 > New Revision: 281395 > > URL:

r281395 - Try harder to not inline dllimport functions referencing non-dllimport functions

Author: hans Date: Tue Sep 13 16:08:20 2016 New Revision: 281395 URL: http://llvm.org/viewvc/llvm-project?rev=281395=rev Log: Try harder to not inline dllimport functions referencing non-dllimport functions In r246338, code was added to check for this, but it failed to take into account implicit