RE: r284060 - Implement MS _BitScan intrinsics

2017-06-20 Thread Erik Schwiebert via cfe-commits
s Subject: Re: r284060 - Implement MS _BitScan intrinsics On Fri, Jun 16, 2017 at 5:08 PM, Duncan P. N. Exon Smith wrote: > > On Jun 16, 2017, at 11:02, Reid Kleckner wrote: > > We should fix it. > > > Agreed. > > We just need a new character code in the builtin fun

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-19 Thread Bruno Cardoso Lopes via cfe-commits
>> Thanks, >> Schwieb >> >> -Original Message- >> From: Erik Schwiebert >> Sent: Friday, June 16, 2017 8:49 AM >> To: 'Bruno Cardoso Lopes' ; Brian Kelley >> ; Tomasz Kukielka >> Cc: dexonsm...@apple.com; Reid Kleckner

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Duncan P. N. Exon Smith via cfe-commits
Brian Kelley <mailto:bkel...@microsoft.com>>; Tomasz Kukielka <mailto:tkuki...@microsoft.com>> > Cc: dexonsm...@apple.com <mailto:dexonsm...@apple.com>; Reid Kleckner > mailto:r...@google.com>>; cfe-commits > mailto:cfe-commits@lists.llvm.org>> > Sub

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Reid Kleckner via cfe-commits
hwiebert > Sent: Friday, June 16, 2017 8:49 AM > To: 'Bruno Cardoso Lopes' ; Brian Kelley < > bkel...@microsoft.com>; Tomasz Kukielka > Cc: dexonsm...@apple.com; Reid Kleckner ; cfe-commits < > cfe-commits@lists.llvm.org> > Subject: RE: r284060 - Implement MS _B

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Erik Schwiebert via cfe-commits
could live with that. Thanks, Schwieb -Original Message- From: Erik Schwiebert Sent: Friday, June 16, 2017 8:49 AM To: 'Bruno Cardoso Lopes' ; Brian Kelley ; Tomasz Kukielka Cc: dexonsm...@apple.com; Reid Kleckner ; cfe-commits Subject: RE: r284060 - Implement MS _BitScan int

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-16 Thread Erik Schwiebert via cfe-commits
OS SDKs!) We'll get back to you ASAP. Schwieb -Original Message- From: Bruno Cardoso Lopes [mailto:bruno.card...@gmail.com] Sent: Thursday, June 15, 2017 4:41 PM To: Erik Schwiebert Cc: dexonsm...@apple.com; Reid Kleckner ; cfe-commits Subject: Re: r284060 - Implement MS _BitScan i

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-15 Thread Bruno Cardoso Lopes via cfe-commits
>> From: dexonsm...@apple.com [mailto:dexonsm...@apple.com] >> Sent: Monday, June 12, 2017 1:55 PM >> To: Reid Kleckner >> Cc: Saleem Abdulrasool ; Albert Gutowski >> ; David Majnemer ; >> cfe-commits ; Erik Schwiebert >> >> Subject: Re: r2

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-13 Thread Bruno Cardoso Lopes via cfe-commits
David Majnemer ; > cfe-commits ; Erik Schwiebert > > Subject: Re: r284060 - Implement MS _BitScan intrinsics > > >> On Jun 12, 2017, at 12:44, Reid Kleckner wrote: >> >>> On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool >>> wrote: >>> I'

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Erik Schwiebert via cfe-commits
m: dexonsm...@apple.com [mailto:dexonsm...@apple.com] Sent: Monday, June 12, 2017 1:55 PM To: Reid Kleckner Cc: Saleem Abdulrasool ; Albert Gutowski ; David Majnemer ; cfe-commits ; Erik Schwiebert Subject: Re: r284060 - Implement MS _BitScan intrinsics > On Jun 12, 2017, at 12:44, Reid Kleckner wr

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Duncan P. N. Exon Smith via cfe-commits
> On Jun 12, 2017, at 12:44, Reid Kleckner wrote: > >> On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool >> wrote: >> I'm worried about changing this signature all the time. I suspect that it >> will cause the following to be emitted for valid code: >> >> warning: incompatible pointer type

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Reid Kleckner via cfe-commits
On Wed, Jun 7, 2017 at 7:31 PM, Saleem Abdulrasool wrote: > I'm worried about changing this signature all the time. I suspect that it > will cause the following to be emitted for valid code: > > warning: incompatible pointer types passing 'unsigned long *' to parameter > of type 'unsigned int *'

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-12 Thread Erik Schwiebert via cfe-commits
. Exon Smith mailto:dexonsm...@apple.com>> Cc: Albert Gutowski mailto:agutow...@google.com>>; Reid Kleckner mailto:r...@google.com>>; David Majnemer mailto:david.majne...@gmail.com>>; cfe-commits mailto:cfe-commits@lists.llvm.org>> Subject: RE: r284060 - Implement

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-08 Thread Erik Schwiebert via cfe-commits
;; cfe-commits mailto:cfe-commits@lists.llvm.org>>; Erik Schwiebert mailto:eri...@microsoft.com>> Subject: Re: r284060 - Implement MS _BitScan intrinsics I'm worried about changing this signature all the time. I suspect that it will cause the following to be emitted for valid

RE: r284060 - Implement MS _BitScan intrinsics

2017-06-08 Thread Erik Schwiebert via cfe-commits
[mailto:compn...@compnerd.org] Sent: Wednesday, June 7, 2017 7:32 PM To: Duncan P. N. Exon Smith Cc: Albert Gutowski ; Reid Kleckner ; David Majnemer ; cfe-commits ; Erik Schwiebert Subject: Re: r284060 - Implement MS _BitScan intrinsics I'm worried about changing this signature all the time. I su

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-07 Thread Saleem Abdulrasool via cfe-commits
I'm worried about changing this signature all the time. I suspect that it will cause the following to be emitted for valid code: warning: incompatible pointer types passing 'unsigned long *' to parameter of type 'unsigned int *' [-Wincompatible-pointer-types] Switching the signature on LP64 soun

Re: r284060 - Implement MS _BitScan intrinsics

2017-06-07 Thread Duncan P. N. Exon Smith via cfe-commits
[... excuse the necromancy...] Hi Albert (and Reid and David), This commit is breaking some uses of -fms-extensions on Apple platforms. In particular, Brian and Erik (CC'ed) build against a version of the Windows SDK on Apple platforms. _BitScanReverse is expected to be 32-bit, matching Wind

r284060 - Implement MS _BitScan intrinsics

2016-10-12 Thread Albert Gutowski via cfe-commits
Author: agutowski Date: Wed Oct 12 17:01:05 2016 New Revision: 284060 URL: http://llvm.org/viewvc/llvm-project?rev=284060&view=rev Log: Implement MS _BitScan intrinsics Summary: _BitScan intrinsics (and some others, for example _Interlocked and _bittest) are supposed to work on both ARM and x86.