Re: r292522 - Don't inline dllimport functions referencing non-imported methods

2017-01-23 Thread Hans Wennborg via cfe-commits
Thanks for reverting! This was indeed broken. I've re-committed it with a fix in r292856. On Fri, Jan 20, 2017 at 12:56 PM, Reid Kleckner via cfe-commits wrote: > The first Chrome DLL build with this change is crashing during compilation: > https://build.chromium.org/p/chromium.fyi/builders/Clan

Re: r292522 - Don't inline dllimport functions referencing non-imported methods

2017-01-20 Thread Reid Kleckner via cfe-commits
The first Chrome DLL build with this change is crashing during compilation: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%28dll%29/builds/8380/ The previous build fails with a link error, so the revision range for the new crash is 292501 - 292526. Only the DLL builders are affe

r292522 - Don't inline dllimport functions referencing non-imported methods

2017-01-19 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Jan 19 15:33:13 2017 New Revision: 292522 URL: http://llvm.org/viewvc/llvm-project?rev=292522&view=rev Log: Don't inline dllimport functions referencing non-imported methods This is another follow-up to r246338. I had assumed methods were already handled by the AST visitor,