Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

> On Jan 31, 2018, at 9:15 AM, Akira Hatanaka wrote: > > > >> On Jan 30, 2018, at 4:32 PM, Saleem Abdulrasool > > wrote: >> >> Thanks for the note here. I’ll try to take a look at that, but, yes, the >> frontend

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

> On Jan 30, 2018, at 4:32 PM, Saleem Abdulrasool wrote: > > Thanks for the note here. I’ll try to take a look at that, but, yes, the > frontend change itself is correct. I’ve seen many, many places where the > ObjCARC passes break down in the backend, and I’ve filed

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

Thanks for the note here. I’ll try to take a look at that, but, yes, the frontend change itself is correct. I’ve seen many, many places where the ObjCARC passes break down in the backend, and I’ve filed a few bugs on it in the hope that someone from Apple would take a look at some point. I’m

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

Hi Saleem, I had to revert this patch since this patch caused crashes in code that was working fine before. As I mentioned in the commit message, I believe this patch is correct, but it causes the objc_retainAutoreleasedReturnValue/objc_autoreleaseReturnValue handshake to fail in some cases

r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

Author: compnerd Date: Sat Feb 11 15:34:18 2017 New Revision: 294872 URL: http://llvm.org/viewvc/llvm-project?rev=294872=rev Log: CodeGen: annotate ObjC ARC functions with ABI constraints Certain ARC runtime functions have an ABI contract of being forwarding. Annotate the functions with the